Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp30307pja; Fri, 22 Nov 2019 03:03:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxR1Af6zBcCz2O4U/12SeXeRz28OHJKSjQfaiRw/IiltJxnO2toHjYAxQ23Cgj01D4/w6NE X-Received: by 2002:a50:d756:: with SMTP id i22mr304111edj.24.1574420616715; Fri, 22 Nov 2019 03:03:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574420616; cv=none; d=google.com; s=arc-20160816; b=gVcg7TIp/TudkC6L99x24K5QF2V2vYjR9m78zhvsD41pGhREZq6CRX2DhdHksKMKI3 PzSLZpSE8PRodp1vx/knpuUUGUBEwOyw0SjuMJ0rUfQJS/69U6LTVtlbSQ4pMYru2NeW qqm9lM6mac0g1chVMAu521ECe/NCWGhvEPH9S0jVxZ71jzA7cIkx6SLbs+WYgc8qGWLf 4QrIjm1aWZNLgDWup4jpKSIvjA0WujJkzT0QIDldec978YMjyGgM3gyjPjv2oktwwvzI mgkjXwrfDweJMCCylokrlKJVQG6q3/BaoOSr8YE5PSJ3+UZmLy5JcZTQAOAfRte22yTN d/Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m+B28ysFTXJoLfWqoA5xa5rcLBgwtwOW7mVOF3nuj20=; b=uyNdLa/8VOWuDLHb6bW5GDIuqrDpwh1BE5K3DB6BMtoRaqKMtI80LqUSyycnDOGr69 TnvNQeU1ar2KoQIt4svufS9XRm+gkuX0GI5azbPHXHvjxPYZP/OOcQayl3/BvscU++6K fF5+8sjPHQ7YL0iCU294QnThJh2HsFCy5FnpWGqPnUfz4R2B89RX1aj89sD+SZQXhWcI P3k+dU8RKjvIfcrqUk00hAKWizQXGGIgyus/cJrtOz7HGjO3UnSmZzU/EmtkfzcYwAU3 rJIUZUtQY2xj/R0VBaGgr1dPhyB4RU2MCCLsWtITrUd5W8KxZq/EdtwZ+1GgViLLCl5X qsBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zbZSo5fG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si3842033eju.310.2019.11.22.03.03.12; Fri, 22 Nov 2019 03:03:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zbZSo5fG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbfKVK7y (ORCPT + 99 others); Fri, 22 Nov 2019 05:59:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:51322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730662AbfKVK7u (ORCPT ); Fri, 22 Nov 2019 05:59:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B01420706; Fri, 22 Nov 2019 10:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420389; bh=GnLDcU3GQlLVz86X48Q6AD2uliaNpA6HTGkKvjNyt+w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zbZSo5fGaLiJJLRCmV+08MyHYIHH8OPVX5fm+rYs7jXd8Jfz6fJBGWnyDph4WdQvI YvmqWdzZmZXEHvZLlXeDWIJujoPZQMrk4e8/neJKxmPNsrg8U3aY4vxR96BjOpo15M xEQYDFh8kauF6I9eRfR66llzVKlG9MUTaR9cEnoM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jordan Crouse , Sibi Sankar , Rob Clark , Sasha Levin Subject: [PATCH 4.19 091/220] msm/gpu/a6xx: Force of_dma_configure to setup DMA for GMU Date: Fri, 22 Nov 2019 11:27:36 +0100 Message-Id: <20191122100919.197631621@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jordan Crouse [ Upstream commit 32aa27e15c28d3898ed6f9b3c98f95f34a81eab2 ] The point of the 'force_dma' parameter for of_dma_configure is to force the device to be set up even if DMA capability is not described by the firmware which is exactly the use case we have for GMU - we need SMMU to get set up but we have no other dma capabilities since memory is managed by the GPU driver. Currently we pass false so of_dma_configure() fails and subsequently GMU and GPU probe does as well. Fixes: 4b565ca5a2c ("drm/msm: Add A6XX device support") Signed-off-by: Jordan Crouse Tested-by: Sibi Sankar Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index 9acb9dfaf57e6..9cde79a7335c8 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1140,7 +1140,7 @@ int a6xx_gmu_probe(struct a6xx_gpu *a6xx_gpu, struct device_node *node) gmu->dev = &pdev->dev; - of_dma_configure(gmu->dev, node, false); + of_dma_configure(gmu->dev, node, true); /* Fow now, don't do anything fancy until we get our feet under us */ gmu->idle_level = GMU_IDLE_STATE_ACTIVE; -- 2.20.1