Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp32202pja; Fri, 22 Nov 2019 03:04:59 -0800 (PST) X-Google-Smtp-Source: APXvYqw4tkJpwfKPxicpw+t0QME4REawEnBk4jTq2b5MGbAi9KjC7x1CbQm15WaKHtVHjgY9BBTp X-Received: by 2002:a50:e68c:: with SMTP id z12mr321027edm.53.1574420699326; Fri, 22 Nov 2019 03:04:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574420699; cv=none; d=google.com; s=arc-20160816; b=J9lpwx4aHgkoOvbOUPA5UGJNBJZmW5q0sSSWyEMlQd2x7TDq28UHXQmE5NTbSHmoi0 u0dZa1PlVpNSohjsHwvBzHE+bS8ltrlMNMGy86K1+KNOFTdhVd1FOQVTjpT6Nyt6FW9A HJ6C9y/in5ia2QZB35o1sSyrqUdTjAtOhnLmItd9vPMKGVS+SHWwhjo84hJFGevKz/0L DoKRe9zfP/caf2L05d47OIM8iAV1ykYkBUUoeZwAoKLlYkowrf3RC+FgDGPN0TwptmUm 3GNgNdT7GECec7tY4bJUbT02I+JJIrb3rISucu1BG3F7PrgGBDVU9HbJ7IMHHtMmErVr PcSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3KbV8YlS5un+QhdEIpoyPK9DocK4qIGa2ILtmxpzEak=; b=ercxWlYsBXeHHaOVjlq5goe/33OAMkpiB1M6ZdGVebhZJpws+gAOjnb/7sol6RQxnD KECwr0u9eLnOcweXYRjEQ1A4b2xB9IH4mgvGrRLoiwDzRnXJbwPoIirxGhZnhO9D2Br6 Zn7BYCIlv+AEWWWiBSnMcVJZOOHdlXexCwLugDwSdJ21B2/X3ZiK/5UD6Bzknvw2OCDI GeRA74YvuDdUex1Yovq0cVSUBIonU0FAZCjh/E+d89iFRCUoHRzF2GnO7txFJPDwrfxL 0iUZO0Gt56SsjUgu2VEgm7xy9VFTT9dCj1uUjwXJQAPfi5tKu4P1rHthaRIHW07buMLR vJfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KM0WrTuh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si1097963ejb.257.2019.11.22.03.04.34; Fri, 22 Nov 2019 03:04:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KM0WrTuh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730559AbfKVLAq (ORCPT + 99 others); Fri, 22 Nov 2019 06:00:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:53132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728932AbfKVLAn (ORCPT ); Fri, 22 Nov 2019 06:00:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3969B20721; Fri, 22 Nov 2019 11:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420442; bh=3/Uq4ZXq7sa6LCZZyXYuOU63UAjEPvJQybSyyern0yY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KM0WrTuhIST3q5olYZBc0wyK3oeOZuEk5rTcLx0J6/Lyq0DyWz2cfrAFZdOMyaYkT peH9shnVrsuQFqST18EcMgZVKmr12+HRacrnu+JDXQWkq62CXYj4YSQC548A3RV0lW EnlWgiq1F+VkIJ9VNOR2IaMGp5bvMH3WlpUBhVik= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Sasha Levin Subject: [PATCH 4.19 107/220] USB: serial: cypress_m8: fix interrupt-out transfer length Date: Fri, 22 Nov 2019 11:27:52 +0100 Message-Id: <20191122100920.470437477@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold [ Upstream commit 56445eef55cb5904096fed7a73cf87b755dfffc7 ] Fix interrupt-out transfer length which was being set to the transfer-buffer length rather than the size of the outgoing packet. Note that no slab data was leaked as the whole transfer buffer is always cleared before each transfer. Fixes: 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where appropriate") Signed-off-by: Johan Hovold Signed-off-by: Sasha Levin --- drivers/usb/serial/cypress_m8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c index e0035c0231202..2c58649fd47a4 100644 --- a/drivers/usb/serial/cypress_m8.c +++ b/drivers/usb/serial/cypress_m8.c @@ -769,7 +769,7 @@ static void cypress_send(struct usb_serial_port *port) usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev, usb_sndintpipe(port->serial->dev, port->interrupt_out_endpointAddress), - port->interrupt_out_buffer, port->interrupt_out_size, + port->interrupt_out_buffer, actual_size, cypress_write_int_callback, port, priv->write_urb_interval); result = usb_submit_urb(port->interrupt_out_urb, GFP_ATOMIC); if (result) { -- 2.20.1