Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp39537pja; Fri, 22 Nov 2019 03:10:22 -0800 (PST) X-Google-Smtp-Source: APXvYqz0RrSV5OCIJ9vIXRYmZghMkE+XElD2R8lbZFYmvUWveibEfWOrfHTI8VSs4LOZeQkakWdf X-Received: by 2002:a17:906:641:: with SMTP id t1mr4076625ejb.1.1574421022676; Fri, 22 Nov 2019 03:10:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421022; cv=none; d=google.com; s=arc-20160816; b=Fy0/VkavF7lro+DQTE6AfZX6kA/uwJnP+4V1QrgtOZidewtwfLtY4S3hJCdHXpeSK5 ipW3Eyo+QtwrGV1C5Rllqyw7KmHnIs0NAigKVYRwKk+xN5so3ENYkD7gqVliP5GCUd1Y 7xKhvSNEYLhH1nm/JkH6a8AliJ1JNT2HjDB/zzr0m1ioSWFQdfwiCjShjQTlzlaa0q1i U2WhYdJTVpa2GHxKSrEv9gjYdT2Pl/eUNgvZkoQOVpShqD2oUyVvpHA6IXfcLQTPJ9hC z8FxVWKC6RryG9jeHcQ/5AinIldDnFSFcZ4XOU+kEAI41lQ7O6m1DQtWCI5qaI7P6/kx De3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ka/15Fb2LCk6DTnuLeGRuxFkb5dEonFZV6udI2rLcys=; b=oxoUQp3ypZC/U0Rky23uae2YfUl5ZBkTLLiY5BO2A3vJF8iYjmbZD1IpgPAgBQH5Di bh/VFtToJFsW16JFjSbQzw/ON4svTSxv95KY8tG2s99TpHAGWpwke95XmeA1OkAk2B5r kwkEF0/URIBYoI6n8BzyLUb39aEXdY0jrs445iU6OlYAcfYCv/cfAjSY0yHgQlxNSpHO 26ew6Tb5z3US98pvvnxYEBd43LdqZBK0KRfeGMVA6xLqINR2IqzE5YKfRTN6qwS/SpWJ arCbht59cAo6I/Rv+3n1ZsWxHvhrC67JCC1gtRrtLs71/hxEByKASnwIaR0PP9sxz7i3 9AVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R98rN+72; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id si11si4003481ejb.71.2019.11.22.03.09.58; Fri, 22 Nov 2019 03:10:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R98rN+72; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731778AbfKVLFw (ORCPT + 99 others); Fri, 22 Nov 2019 06:05:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:33618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730559AbfKVLFu (ORCPT ); Fri, 22 Nov 2019 06:05:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC07B2070E; Fri, 22 Nov 2019 11:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420750; bh=mHyJix8TS0iTdx7zM4Zt5aMG7j8CE7oo13sYuj57jpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R98rN+72j2hiVWGMXUBThcO8F1n04Bn+utztytYBMKzXdlTf8x5IiCVY/Pbl++Psr MTTx8VTbcxW41vLwuOjEIGVxgMuZvQLbz6m0how9X9NG7rue8xrm2649qPs7k+6wow tUelbvAfVWtVPys247xm92TUaSATzTG5bxudP1vc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huibin Hong , Emil Renner Berthing , Mark Brown , Sasha Levin Subject: [PATCH 4.19 211/220] spi: rockchip: initialize dma_slave_config properly Date: Fri, 22 Nov 2019 11:29:36 +0100 Message-Id: <20191122100928.876722792@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huibin Hong [ Upstream commit dd8fd2cbc73f8650f651da71fc61a6e4f30c1566 ] The rxconf and txconf structs are allocated on the stack, so make sure we zero them before filling out the relevant fields. Signed-off-by: Huibin Hong Signed-off-by: Emil Renner Berthing Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index fdcf3076681b5..185bbdce62b14 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -445,6 +445,9 @@ static int rockchip_spi_prepare_dma(struct rockchip_spi *rs) struct dma_slave_config rxconf, txconf; struct dma_async_tx_descriptor *rxdesc, *txdesc; + memset(&rxconf, 0, sizeof(rxconf)); + memset(&txconf, 0, sizeof(txconf)); + spin_lock_irqsave(&rs->lock, flags); rs->state &= ~RXBUSY; rs->state &= ~TXBUSY; -- 2.20.1