Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp41881pja; Fri, 22 Nov 2019 03:12:19 -0800 (PST) X-Google-Smtp-Source: APXvYqzXmm91z0+YbOHn6RatNeniU2r9Lm9DM8ruE03qF9X9AZraei47ltlaAMEqKXgVGti3nKmi X-Received: by 2002:a17:906:f259:: with SMTP id gy25mr20508239ejb.297.1574421139346; Fri, 22 Nov 2019 03:12:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421139; cv=none; d=google.com; s=arc-20160816; b=ZBps4Fz4fblPHJg/+P6x/hwUx0rhcyqwRRxCSMYuRErs9xMM2T5XYbSXvIKUT/523K Xr9d/dVT4AnfBMM+jWLz/icb9QFTBiMHQx3/Imyau2bW3BX5AQv+OIAVJSnRWit2MMht W1L5RpdusxaG21T8fFwndKcaO/6Qj9ZEp6GillPHjxQR1hIBbCnVhub2yOaMOGXYUGXs 6rjoN0P4aFzZdThzI+zEjZCQIF7aYRfaIsoRC80zBNElWFaLmUiON8WQU2W2ZuUgOHX4 0hAYcogWkniJsJ4V85fsyJXcwo/off/bJ1oY2nruHiLKtzDLCJcZ/e2skqSehC/Fcs7b pwxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ehJxH9i2WQImW0a78Sf45mLxBndCtbLp7iHITP4Cm/s=; b=NYQ56ZjgdedRy0RiQgc3DwLYCmvRs0pMz9CO4jg0/y49kBm+B8lNgt0sGn1gyJcS2O C7OP2uKXgUmNsAkb6HjNg5fVuhwB6Ry/tqMDMjSAJBtOBKQGMcQGmC32efvTBdhhqefz M+E7NB6t9bscY0rk2HIusMrmlRuneP9zmXXbHZlzCMwjo0ccv8HTpt8YQIca8H5lUpAL h5tvDS7ghw8q0RCeD8okxPBEVa7SoUCJka6/4Sy6QSAmTvXhJ4p8Th0UCI+7SZOEXtqn dXzlBdlO1GZYE1UEGsibFv7Qlarw37CKaSuazydfmzTHJbcQRdBXYGXfnoldr+iCt/ga I29w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l8Bny6AF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16si4441742edd.314.2019.11.22.03.11.54; Fri, 22 Nov 2019 03:12:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l8Bny6AF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731364AbfKVLCy (ORCPT + 99 others); Fri, 22 Nov 2019 06:02:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:56632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731356AbfKVLCt (ORCPT ); Fri, 22 Nov 2019 06:02:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB1F22075E; Fri, 22 Nov 2019 11:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420569; bh=0gEzsh+7Ngn7kbU3KfbwyUiSURyxIcBfrRMxOaEwNbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l8Bny6AFkiC9EAXwhdf3nrqwCM6txxIVTdpoic7uVHnMZxHHJkgm1HDZVBrwCdUWh +H8j/v5RXp2t8xZpmZRTsd5gzIituzA77x/PI4sj2m2YM2vYdOMvNBm7j/S/CFKT3Z 6dqtMHjzhdxKfGjwQW5lG4Z1FIj6MkknIbzlKvKU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Wolfram Sang , Ulf Hansson , Sasha Levin Subject: [PATCH 4.19 150/220] mmc: renesas_sdhi_internal_dmac: set scatter/gather max segment size Date: Fri, 22 Nov 2019 11:28:35 +0100 Message-Id: <20191122100923.526919896@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Niklas Söderlund [ Upstream commit 54541815b43f4e49c82628bf28bbb31d86d2f58a ] Fix warning when running with CONFIG_DMA_API_DEBUG_SG=y by allocating a device_dma_parameters structure and filling in the max segment size. The size used is the result of a discussion with Renesas hardware engineers and unfortunately not found in the datasheet. renesas_sdhi_internal_dmac ee140000.sd: DMA-API: mapping sg segment longer than device claims to support [len=126976] [max=65536] Reported-by: Geert Uytterhoeven Signed-off-by: Niklas Söderlund [wsa: simplified some logic after validating intended dma_parms life cycle and added comment] Signed-off-by: Wolfram Sang Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c index f4aefa8954bfc..382172fb3da8f 100644 --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c @@ -310,12 +310,20 @@ static const struct soc_device_attribute gen3_soc_whitelist[] = { static int renesas_sdhi_internal_dmac_probe(struct platform_device *pdev) { const struct soc_device_attribute *soc = soc_device_match(gen3_soc_whitelist); + struct device *dev = &pdev->dev; if (!soc) return -ENODEV; global_flags |= (unsigned long)soc->data; + dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms), GFP_KERNEL); + if (!dev->dma_parms) + return -ENOMEM; + + /* value is max of SD_SECCNT. Confirmed by HW engineers */ + dma_set_max_seg_size(dev, 0xffffffff); + return renesas_sdhi_probe(pdev, &renesas_sdhi_internal_dmac_dma_ops); } -- 2.20.1