Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp51878pja; Fri, 22 Nov 2019 03:20:06 -0800 (PST) X-Google-Smtp-Source: APXvYqxDfJKBCK5h5KQLQSXOAc0R2SHTksfeqlVdVtusLzLhp3hLorc0OE0Aia8crVHMM1Yv6QaJ X-Received: by 2002:aa7:cc0f:: with SMTP id q15mr391726edt.71.1574421605994; Fri, 22 Nov 2019 03:20:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421605; cv=none; d=google.com; s=arc-20160816; b=J/HthvXxPV3scxqGELX3GFAnhINH0vE65Vwo86uzULyHuXpbM6K0AHMa3A1HHpievI I26h6v8B7UPdxXRxrN8a3HSV8b5lXgu0H5aUO/Aq8o2ruh6UrmV3fuPcpN0C/zF57zPz /TAmfSy2M/kUF3EQiFKQPiH2eDHh3rNvkY4V9SFKUnIqRLzVDFL7/YHXfO2y+gYkn41h 6aCxno7RJhN+qZPfNYbTyVGstiOu03rBeulWhfPl4mFAITMtkd0s0kliwTXZ8pzGfMsu u6/5uH/wihI8xwqJN0TifQxUVLUSIoHa+uyySiiYp2fmjmeZ9QixImyNj4jjBaip0wvN cEcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YjkznhIJqSTId1MDrFzvTp9/rTDRi8XEItJwj/ouWNA=; b=wndwxbRpoDlGIL3++1uhQIA4NuEGmD2b2Gm/mSWQnf+YSIXaJTCPTb0WynxSK3cx87 hNwlF9tuVwSYUeHDXqoRPi0BwbZmT4lhF/YEZFJMW7a6z5hTgnmKOopyZJfRFx0f96rN fc/dp4wLf9Wp7/UgDyWOgUs4U0uDBqQ1549JdNfhDyKdRCD//WETTF5q/48fWLFZHiti vW4ZoKWKz+W2NP5xwFsED+DO9hp6fj3rMDzViA8R2nmXRp/ZYMjb+q/AMmEXg5IPPYsW 3HVZozwRxwPy9eMG2rPL/MUsSXZlkHCer1KI1vBxXCc9CqD5j9RAMacFiEwKkdK+wWd+ DLjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p3ddhxlw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si4255576edy.83.2019.11.22.03.19.18; Fri, 22 Nov 2019 03:20:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p3ddhxlw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729350AbfKVKtj (ORCPT + 99 others); Fri, 22 Nov 2019 05:49:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:59046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730031AbfKVKte (ORCPT ); Fri, 22 Nov 2019 05:49:34 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C7592071F; Fri, 22 Nov 2019 10:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574419774; bh=km4X5vKqo7Inc5aIAMHNteD9crBieiW9GgVbiAH/MyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p3ddhxlwpb5r1bBnWow9Wp+OVZRuFaWJi608c09qRzKjJFsIUUW2+WmSfqeQ5PAMT HR+W1JeD7XMT0xDKHYMSyKMvmN8G1u43k+BGAJ+301qltLVyANHUSo/QACPE4xFAVC gOmW58vCohekyzrGfDQEm0UvDAY3KLLcfwOu9gEs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolin Chen , Guenter Roeck , Sasha Levin Subject: [PATCH 4.9 217/222] hwmon: (ina3221) Fix INA3221_CONFIG_MODE macros Date: Fri, 22 Nov 2019 11:29:17 +0100 Message-Id: <20191122100918.207823796@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100830.874290814@linuxfoundation.org> References: <20191122100830.874290814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolin Chen [ Upstream commit 791ebc9d34e9d212fc03742c31654b017d385926 ] The three INA3221_CONFIG_MODE macros are not correctly defined here. The MODE3-1 bits are located at BIT 2-0 according to the datasheet. So this patch just fixes them by shifting all of them with a correct offset. However, this isn't a crital bug fix as the driver does not use any of them at this point. Signed-off-by: Nicolin Chen Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/ina3221.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index e6b49500c52ae..8c9555313fc3d 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -38,9 +38,9 @@ #define INA3221_WARN3 0x0c #define INA3221_MASK_ENABLE 0x0f -#define INA3221_CONFIG_MODE_SHUNT BIT(1) -#define INA3221_CONFIG_MODE_BUS BIT(2) -#define INA3221_CONFIG_MODE_CONTINUOUS BIT(3) +#define INA3221_CONFIG_MODE_SHUNT BIT(0) +#define INA3221_CONFIG_MODE_BUS BIT(1) +#define INA3221_CONFIG_MODE_CONTINUOUS BIT(2) #define INA3221_RSHUNT_DEFAULT 10000 -- 2.20.1