Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp75258pja; Fri, 22 Nov 2019 03:40:40 -0800 (PST) X-Google-Smtp-Source: APXvYqwY5/jUC3uOX2SYk4A6sHL4w60w7J+SN4R5Ip/Xe9MCTW9kH0lpgO3/gouKuH2Se+X9F0hA X-Received: by 2002:a50:c191:: with SMTP id m17mr488299edf.259.1574422839993; Fri, 22 Nov 2019 03:40:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574422839; cv=none; d=google.com; s=arc-20160816; b=C+ZLIbKqPr/APgYscdyr0hVeMUil5tyiVlDih96phLJovBBdtzuGz/gcQwiYaHUc1Y aauOSVPk3Xlamh1RcbgwoBSIjTMMRZg/+NWRIG3IRjYFHvocJ5R+rDqz8mpfRI9X24tT Riw5gW9qz9s0efvf7GnkVpsjk18xwtb1brZFvbQRaHg25aX58ZT7+wn4DD7PzMFLV74B kAoBAFPKPuQb8zzTKNt7YzbhdmJrWGGJrKTdsJoDq4HWeIjBbkJCG9LzydS4XMYPNyCi zHjmAP2gtB2q9y45I0kC1A0QH6hIANhLqscnuZijoeWpmUmYBQQuKe7Jy87iiftx1PL9 i23w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WB3zm/IFUeUec3M/g1ZIBLtErXoXlK0Px0+7g5dssiA=; b=LEbXm7iIl5DZbxN7kSK4VZgMa1VWRE4OUEGj+7/N3N9zBcTXHHARyl9nJ87127yWq+ mGQUo3pF469nOQuU+zAcODFvtyqDnWWnpyQ5MTQA/CCmBW1TxIzD6TyjZeuOSa0vht9E MNEa/Cwy29cyn3Tyz+ZGlzNgCFeiUhiBGdn/O6Cep0Op7cQ9n1jxTz8DQ7yzN6xXEC9p t+l7oc3TXevi3JQV/XSyuA2KnkCN6UcBPUFFXUq8vvIaztksQC/pfj7iu7sQr0wTPpTw iwv2gU5gatSfKq2yXmMg1LWUTsCEmFKNI/MUuqBaxIRg8Y5ULdTGYRKUFcLRFwoJHzun WT+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WPesMX3v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si1880962edu.376.2019.11.22.03.40.16; Fri, 22 Nov 2019 03:40:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WPesMX3v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727152AbfKVLjC (ORCPT + 99 others); Fri, 22 Nov 2019 06:39:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:34336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbfKVLjC (ORCPT ); Fri, 22 Nov 2019 06:39:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25C5B20704; Fri, 22 Nov 2019 11:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574422741; bh=S8YSy/ai1WXllwXqyBcZhi6USknPsNtdTGIyQ9A5nUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WPesMX3vTs6GUUlwSXkYKH5F2cm7j6BMSdoGnVsX62f+mwj43TcUVRS2x/T8cAcEj saqXOSJQ5ArTLBA+9yefTmEADffF7BiSTT5PQ2dzeyye0y7atF+2G6ydIiqaFTw3yY Zncgo9zyJ8I31FDufCab5ePFQ0zIhFmiznwaIMlU= Date: Fri, 22 Nov 2019 12:38:59 +0100 From: Greg KH To: Chen Wandun Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] {tty: serial, nand: onenand}: remove variable 'ufstat' set but not used Message-ID: <20191122113859.GA2026910@kroah.com> References: <1574421159-113624-1-git-send-email-chenwandun@huawei.com> <20191122111410.GA2024666@kroah.com> <62b2cfc1-416c-f7c7-3029-6dd7ad12ea46@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62b2cfc1-416c-f7c7-3029-6dd7ad12ea46@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2019 at 07:33:47PM +0800, Chen Wandun wrote: > > > On 2019/11/22 19:14, Greg KH wrote: > > On Fri, Nov 22, 2019 at 07:12:39PM +0800, Chen Wandun wrote: > > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > > > drivers/tty/serial/samsung_tty.c: In function s3c24xx_serial_rx_chars_dma: > > > drivers/tty/serial/samsung_tty.c:549:24: warning: variable ufstat set but not used [-Wunused-but-set-variable] > > > > > > Signed-off-by: Chen Wandun > > > > Your subject line is really odd, can you please fix that up and resend? > I check the git log of drivers/tty/serial/samsung_tty.c, > it seem like the subject line should be: > {tty: serial, nand: onenand}: samsung: remove variable 'ufstat' set but not used > > Is that OK? No. What does this patch have to do with nand? That was from a previous patch that modified two drivers at once. You are not touching the nand driver. thanks, greg k-h