Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191121162520.10120-1-marco.franchi@nxp.com> <20191121162520.10120-2-marco.franchi@nxp.com>
 <CAOMZO5ByMkp1i=rMScgadT9_ucnsxqn_pnSP4bmLUPnxPdYHvw@mail.gmail.com>
In-Reply-To: <CAOMZO5ByMkp1i=rMScgadT9_ucnsxqn_pnSP4bmLUPnxPdYHvw@mail.gmail.com>
From:   Marco Franchi <marcofrk@gmail.com>
Date:   Fri, 22 Nov 2019 08:56:22 -0300
Message-ID: <CAM4PwSWJYrN=xSWNiwxHYS9XMWJFmnpAByVhsOV75kBBF4M3Xg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: add initial support for
 Google i.MX 8MQ Phanbell
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Marco Antonio Franchi <marco.franchi@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "atv@google.com" <atv@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Fabio,

Em qui., 21 de nov. de 2019 =C3=A0s 15:22, Fabio Estevam
<festevam@gmail.com> escreveu:
>
> Hi Marco,
>
> On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
> <marco.franchi@nxp.com> wrote:
> >
> > This patch adds the device tree to support Google Coral Edge TPU,
> > historicaly named as fsl-imx8mq-phanbell, a computer on module
> > which can be used for AI/ML propose.
> >
> > It introduces a minimal enablement support for this module and
> > was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell
>
> Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
> they are different boards.
>
> > +       memory@40000000 {
> > +               device_type =3D "memory";
> > +               reg =3D <0x00000000 0x40000000 0 0xc0000000>;
>
> The memory size here does not match with the one used in the Google repo.
Thanks.
>
> With these changes you can add:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Ok, I will add it at the v3.

Best regards,
Marco