Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp184688pja;
        Fri, 22 Nov 2019 05:10:50 -0800 (PST)
X-Google-Smtp-Source: APXvYqybSooNU3QZGWyNl59/mIfxdhaVn0wxf0JGnZwL10IdVIiiBbxAQOBQcjlwSWsNZbkbkfla
X-Received: by 2002:a05:6402:142c:: with SMTP id c12mr961179edx.96.1574428250424;
        Fri, 22 Nov 2019 05:10:50 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1574428250; cv=none;
        d=google.com; s=arc-20160816;
        b=DokE7iUiAXtyYm/IkFSfLvHkhvg8S5UObZQGV/95/L/b0KNEh60oGtxGtKrPm9hAjF
         WnO8E26hD4Y9m/3DEei25Cn4vtYXFZ2mt1fL/V7M3krUS0ZBjb+LrmXytIvqqIS9ta2X
         SDjFOa8P9VizDhREZ7sgyxLoRMIfRaGdepzEvV1C8wFngtP/TpfsGHwvge+zX65tWf3G
         Oqb8pEYubM6mrQD1PEoNQXTeEbtverpf3AM2KDBg4NorFO4Gt3vKQVgmnQtmtNADwaqE
         ZqUnezg8OkT5RwIaLxL8SjcmR4iMQrLJ/ht12tAPwWXbj6V/l/lRZzxulbdPKF4DBCpC
         xQoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:message-id:in-reply-to:subject
         :cc:to:from:date:content-transfer-encoding:mime-version
         :dkim-signature;
        bh=//5nPzIuRm2evQRb9acrI4hqDZiiDLIkRjl4f5sxneQ=;
        b=0myaYhqhlmCdzV2pvPj7vRV19sc97ZLsDkoxSr1dJ/y2N2QH87Jh36osLfAlCz8x86
         wSxDQvE37HFmh1f3b8R5UeGuOEN4oD8SBc53W/HC1iJkKNO4bRiDwMXF6fS83bAcZh9d
         LfrwCm9k6Foi2A1uPMZ6A/ocZVgEW6FvnuAII3EUZfOaZJJXlMkxo4HbfrfVoBnk01qH
         8l12wtyTBARau0ThuiHFhNk7GH6/BZCNVIqhGDMuaW6w+jWKH5wXWSEp8LO6H/BxWeSw
         EuzTVj6d2RYkrqu4mvMuijqimTYcgWILNhrd2KeDZE9aTQM32JEO2NAzcmpZ1Kp/glRE
         /Ouw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=Fyrp8yuJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id fx21si4108326ejb.254.2019.11.22.05.10.25;
        Fri, 22 Nov 2019 05:10:50 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=Fyrp8yuJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727175AbfKVNIM (ORCPT <rfc822;austinkernel.kim@gmail.com>
        + 99 others); Fri, 22 Nov 2019 08:08:12 -0500
Received: from ssl.serverraum.org ([176.9.125.105]:35661 "EHLO
        ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726712AbfKVNIM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Nov 2019 08:08:12 -0500
Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ssl.serverraum.org (Postfix) with ESMTPSA id C8C842304F;
        Fri, 22 Nov 2019 14:08:08 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
        t=1574428089;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
        bh=//5nPzIuRm2evQRb9acrI4hqDZiiDLIkRjl4f5sxneQ=;
        b=Fyrp8yuJV16DLrKi+FF4jNZLBtL0W4BGrdemubN8pw2rZzEV79OsvUW4elJJos5Ec30Tgk
        OPbn46jipXAN8EWBWg3ocL5WBCURrjYE8vf5JuM5SOnf9Mmny/VBEqBLbXI2qOT25Z7ICJ
        zzAkke/VvecTIFaDsLAXvZTe1oP7MXA=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 22 Nov 2019 14:08:08 +0100
From:   Michael Walle <michael@walle.cc>
To:     linus.walleij@linaro.org
Cc:     bgolaszewski@baylibre.com, devicetree@vger.kernel.org,
        hui.song_1@nxp.com, leoyang.li@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, mark.rutland@arm.com,
        robh+dt@kernel.org, shawnguo@kernel.org
Subject: Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode
 bug fixs.
In-Reply-To: <CACRpkdYhLoGdGQt_jzj5aFa-EY_kMimoVShi7QFLG3sZbC436w@mail.gmail.com>
Message-ID: <563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc>
X-Sender: michael@walle.cc
User-Agent: Roundcube Webmail/1.3.8
X-Spamd-Bar: +
X-Spam-Level: *
X-Rspamd-Server: web
X-Spam-Status: No, score=1.40
X-Spam-Score: 1.40
X-Rspamd-Queue-Id: C8C842304F
X-Spamd-Result: default: False [1.40 / 15.00];
         ARC_NA(0.00)[];
         FROM_HAS_DN(0.00)[];
         TO_MATCH_ENVRCPT_ALL(0.00)[];
         TAGGED_RCPT(0.00)[dt];
         MIME_GOOD(-0.10)[text/plain];
         TO_DN_NONE(0.00)[];
         DKIM_SIGNED(0.00)[];
         RCPT_COUNT_SEVEN(0.00)[11];
         NEURAL_HAM(-0.00)[-0.923];
         RCVD_COUNT_ZERO(0.00)[0];
         FROM_EQ_ENVFROM(0.00)[];
         MIME_TRACE(0.00)[0:+];
         MID_RHS_MATCH_FROM(0.00)[];
         SUSPICIOUS_RECIPS(1.50)[]
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> From: Song Hui <hui.song_1@nxp.com>
>> 
>> On these boards, the irq_set_type must point one valid function 
>> pointer
>> that can correctly set both edge and falling edge.
>> 
>> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> 
> Patch applied!
> 
> Yours,
> Linus Walleij

mhh.. this bug should already be fixed in a better way with [1]:
   gpio: mpc8xxx: Don't overwrite default irq_set_type callback

-michael

[1] 
https://lore.kernel.org/lkml/CACRpkdZ5eWHEV-oN77QxH9X4DZRUB3zM=gP=+rM=ZLAX6Wxw9w@mail.gmail.com/