Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Nov 2019 14:20:35 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] perf mmap: declare type for cpu mask of arbitrary
 length
Message-ID: <20191122131513.GE17308@krava>
References: <26d1512a-9dea-bf7e-d18e-705846a870c4@linux.intel.com>
 <0c716b33-a91e-2972-637f-e7c3a187fa77@linux.intel.com>
MIME-Version: 1.0
In-Reply-To: <0c716b33-a91e-2972-637f-e7c3a187fa77@linux.intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 20, 2019 at 12:37:48PM +0300, Alexey Budankov wrote:
>=20
> Declare a dedicated struct map_cpu_mask type for cpu masks of=20
> arbitrary length. Mask is available thru bits pointer and the=20
> mask length is kept in nbits field. mmap_cpu_mask_bytes() macro=20
> returns mask storage size in bytes.
>=20
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
>  tools/perf/util/mmap.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h
> index bee4e83f7109..a218a0eb1466 100644
> --- a/tools/perf/util/mmap.h
> +++ b/tools/perf/util/mmap.h
> @@ -15,6 +15,15 @@
>  #include "event.h"
> =20
>  struct aiocb;
> +
> +struct mmap_cpu_mask {
> +=09unsigned long *bits;
> +=09size_t nbits;
> +};
> +
> +#define mmap_cpu_mask_bytes(m) \

we try to have all macros upper case

> +=09(BITS_TO_LONGS(((struct mmap_cpu_mask *)m)->nbits) * sizeof(unsigned =
long))

we have BITS_TO_BYTES

thanks,
jirka

> +
>  /**
>   * struct mmap - perf's ring buffer mmap details
>   *
> --=20
> 2.20.1
>=20