Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Nov 2019 14:22:26 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] perf record: adapt affinity to machines with
 #CPUs > 1K
Message-ID: <20191122132226.GF17308@krava>
References: <26d1512a-9dea-bf7e-d18e-705846a870c4@linux.intel.com>
 <2561f736-bdb5-a10a-1a5d-590ad499ce49@linux.intel.com>
MIME-Version: 1.0
In-Reply-To: <2561f736-bdb5-a10a-1a5d-590ad499ce49@linux.intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 20, 2019 at 12:38:57PM +0300, Alexey Budankov wrote:

SNIP

> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
> index 063d1b93c53d..070b1873cd45 100644
> --- a/tools/perf/util/mmap.c
> +++ b/tools/perf/util/mmap.c
> @@ -23,6 +23,7 @@
>  #include "mmap.h"
>  #include "../perf.h"
>  #include <internal/lib.h> /* page_size */
> +#include <linux/bitmap.h>
> =20
>  size_t mmap__mmap_len(struct mmap *map)
>  {
> @@ -215,7 +216,7 @@ void mmap__munmap(struct mmap *map)
>  =09auxtrace_mmap__munmap(&map->auxtrace_mmap);
>  }
> =20
> -static void build_node_mask(int node, cpu_set_t *mask)
> +static void build_node_mask(int node, struct mmap_cpu_mask *mask)
>  {
>  =09int c, cpu, nr_cpus;
>  =09const struct perf_cpu_map *cpu_map =3D NULL;
> @@ -228,28 +229,43 @@ static void build_node_mask(int node, cpu_set_t *ma=
sk)
>  =09for (c =3D 0; c < nr_cpus; c++) {
>  =09=09cpu =3D cpu_map->map[c]; /* map c index to online cpu index */
>  =09=09if (cpu__get_node(cpu) =3D=3D node)
> -=09=09=09CPU_SET(cpu, mask);
> +=09=09=09set_bit(cpu, mask->bits);
>  =09}
>  }
> =20
> -static void perf_mmap__setup_affinity_mask(struct mmap *map, struct mmap=
_params *mp)
> +static int perf_mmap__setup_affinity_mask(struct mmap *map, struct mmap_=
params *mp)
>  {
> -=09CPU_ZERO(&map->affinity_mask);
> +=09map->affinity_mask.nbits =3D cpu__max_cpu();
> +=09map->affinity_mask.bits =3D bitmap_alloc(map->affinity_mask.nbits);
> +=09if (!map->affinity_mask.bits)
> +=09=09return 1;

I guess this works, but please return < 0 on error

thanks,
jirka