Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CACRpkdYhLoGdGQt_jzj5aFa-EY_kMimoVShi7QFLG3sZbC436w@mail.gmail.com>
 <563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc>
In-Reply-To: <563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 22 Nov 2019 14:29:39 +0100
Message-ID: <CACRpkdZWP0CSDGPjkUOTuEkDSvBpoW0tN3ia+B74s1dfFGNinw@mail.gmail.com>
Subject: Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode
 bug fixs.
To:     Michael Walle <michael@walle.cc>
Cc:     Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Hui Song <hui.song_1@nxp.com>,
        Leo Li <leoyang.li@nxp.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 22, 2019 at 2:08 PM Michael Walle <michael@walle.cc> wrote:

> >> From: Song Hui <hui.song_1@nxp.com>
> >>
> >> On these boards, the irq_set_type must point one valid function
> >> pointer
> >> that can correctly set both edge and falling edge.
> >>
> >> Signed-off-by: Song Hui <hui.song_1@nxp.com>
> >
> > Patch applied!
> >
> > Yours,
> > Linus Walleij
>
> mhh.. this bug should already be fixed in a better way with [1]:
>    gpio: mpc8xxx: Don't overwrite default irq_set_type callback

OK I drop this patch.

Yours,
Linus Walleij