Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp436598ybc; Fri, 22 Nov 2019 07:33:59 -0800 (PST) X-Google-Smtp-Source: APXvYqypjJWMf27RiOs174OAQrMO19vOfUyJpwfIhqgD8dM3eb6XBV8ibITGXPYoJrJfDbGEGCn0 X-Received: by 2002:a50:9f65:: with SMTP id b92mr1813003edf.63.1574436838874; Fri, 22 Nov 2019 07:33:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574436838; cv=none; d=google.com; s=arc-20160816; b=EMAZMhINP2VSVXcqIyXd7Q35OswhgkBZpNdRNLZvcOVr7eWMVfouzCFa7N9XcTNiU6 pDcZhLkb8YqHg3IZObdi4JPP7oxiDlnOq58U1oOkNKYF8+5xkPRmZrpxNPkPi3yBlfuv HZJiftYFt5oqBaKPw9pynTCP6o1EhNnYZ6Z95duxUsh0g1Fsb/Qn9la8F0zzwtei1yTA r54hErNv2FZgu0lFv2ApkZAFv5DsvsBX3TaJPSjk0SSyTJcNi0eSLtjo/bGWle4w7FGI 7F1cB1DueSmdLPIricKQ6E+hn6+PjEqAOJNtCInR31DoM50WJnbV3jnZa9MJquT90NGv 9hng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-disposition:mime-version:references:in-reply-to:subject:cc :to:from:message-id:date:dkim-signature; bh=3dYqDBTtgP5XtAXKi8VqGBK1T+2eM5ua2xkGVDRu3sU=; b=YD3oiH388IB3QiYyjBI5H7DpUgBc2qfIVodoEIhH/ol43+5M1hZxjQqVppkp1FxKgy Rzr4AMMucjGQMOu6vsXqOxLtmrSiNugM5GASFoiwDTgs7X5TNpxn18kNiG+AJoHzCBlX BiMXnJJVpbs3IytVQytTYUzcWhZJjadPIo3I7vi77xvuNxjQjY+UEonWNGdFcc0+EtSp 9SQFyPyaVHk5FwLLqvY4yaQbwvn6q+x3rKIKTrcG+dy9MR6qjrqYv5PhfYptx/BPEPNx 6JMU8bU9VxIMIVl3VTRVSeynK6jd2+VIdAWcS70R66nAcB1VPqahK+JQxB+ffpeLIit+ nc2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wko8uZW+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2si4397312edy.215.2019.11.22.07.33.34; Fri, 22 Nov 2019 07:33:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wko8uZW+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbfKVPck (ORCPT + 99 others); Fri, 22 Nov 2019 10:32:40 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:46150 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKVPcj (ORCPT ); Fri, 22 Nov 2019 10:32:39 -0500 Received: by mail-qt1-f193.google.com with SMTP id r20so8189614qtp.13; Fri, 22 Nov 2019 07:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=3dYqDBTtgP5XtAXKi8VqGBK1T+2eM5ua2xkGVDRu3sU=; b=Wko8uZW+HZHX101h/glfPk2TwQpX8eA3RoRJBlvcPjKO1YFB1gAZNm/aJKbEeWM2mC WoLhmD4VPMBtvS724RLDe7TmnR9C2GjaykNl6ZO1A5l3gqQ/aYDLVCAIzyho/j5jW5tM B1rZjzj+OpHMmHNyz8V25I1+PEwBD/01txRDavVizPaFck1cRiLwIxIbMOwbV8FE13oy HPfw2WK0ktZbufdrr35VjTjsi26eWHz+N4cfFynalx0qoX25B8r7BWjCYanXuYI60lY5 /ZveS/yy8OKJQKS4CvmE4p6zvLrqrRcRxOuhDnK09lgIRspFCyM6HKpJGJwgeQYtRHOg OQqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=3dYqDBTtgP5XtAXKi8VqGBK1T+2eM5ua2xkGVDRu3sU=; b=CD7rWBQcn67sgAR4FYU0Wr0MSy0tzKxScSCG342hq8JKMgV4/iIVLCWQDLQebMsbpD JRONRqIVJsj2RhRZGmeHGN9Pj762NmOHkIF1dRFNN+3MwfOgsW9FAVX/fmJwWv1WLSLT 2Y7MgF2Z7rpOclCgsFEfT4vRsH+ZRbSiZBIt2IY7uEMwgK3hCxUkER6Pgra2Z0jUEjlX iK07j9sXmOCNcMdPHDT4MBBVZ3bDa1qkrHXfU0LbOaGc8g/A45XI7UaAjqlMq1E+Ldm/ 77uWed8GJPaeZSFOzLOJV7Gow1DkN7qd1mLkhWbsYXuPWJTW3+2FHxX20VjOd7b+HODc 4NDg== X-Gm-Message-State: APjAAAVXLz/QA5WhVsxxva5Py1riHeYppLjTiR9QqMryGYjIUXy/qtqx IxLGfJ82GribpNsmMKRVw8w= X-Received: by 2002:ac8:661a:: with SMTP id c26mr14774515qtp.317.1574436758716; Fri, 22 Nov 2019 07:32:38 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id v189sm3149907qkc.37.2019.11.22.07.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 07:32:37 -0800 (PST) Date: Fri, 22 Nov 2019 10:32:36 -0500 Message-ID: <20191122103236.GB1112895@t480s.localdomain> From: Vivien Didelot To: Chen Wandun Cc: vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chenwandun@huawei.com Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings In-Reply-To: <1574425965-97890-1-git-send-email-chenwandun@huawei.com> References: <1574425965-97890-1-git-send-email-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Nov 2019 20:32:45 +0800, Chen Wandun wrote: > Fix following sparse warnings: > drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static? > > Signed-off-by: Chen Wandun Reviewed-by: Vivien Didelot