Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Nov 2019 08:36:50 -0800
From:   John Fastabend <john.fastabend@gmail.com>
To:     Brian Vazquez <brianvv@google.com>,
        Brian Vazquez <brianvv.kernel@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S . Miller" <davem@davemloft.net>
Cc:     Yonghong Song <yhs@fb.com>, Stanislav Fomichev <sdf@google.com>,
        Petar Penkov <ppenkov@google.com>,
        Willem de Bruijn <willemb@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, Brian Vazquez <brianvv@google.com>
Message-ID: <5dd80ea2da121_690a2ae784a225c44f@john-XPS-13-9370.notmuch>
In-Reply-To: <20191119193036.92831-2-brianvv@google.com>
References: <20191119193036.92831-1-brianvv@google.com>
 <20191119193036.92831-2-brianvv@google.com>
Subject: RE: [PATCH v2 bpf-next 1/9] bpf: add
 bpf_map_{value_size,update_value,map_copy_value} functions
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Brian Vazquez wrote:
> This commit moves reusable code from map_lookup_elem and map_update_elem
> to avoid code duplication in kernel/bpf/syscall.c.
> 
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> ---
>  kernel/bpf/syscall.c | 271 ++++++++++++++++++++++++-------------------
>  1 file changed, 151 insertions(+), 120 deletions(-)
> 

Nice bit of cleanup.

Acked-by: John Fastabend <john.fastabend@gmail.com>