Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Nov 2019 09:31:35 -0800 (PST)
Message-Id: <20191122.093135.32405983321803856.davem@davemloft.net>
To:     helmut.grohne@intenta.de
Cc:     yuehaibing@huawei.com, andrew@lunn.ch, f.fainelli@gmail.com,
        hkallweit1@gmail.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH] mdio_bus: revert inadvertent error code change
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191122091711.GA31495@laureti-dev>
References: <20191122091711.GA31495@laureti-dev>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Helmut Grohne <helmut.grohne@intenta.de>
Date: Fri, 22 Nov 2019 10:17:13 +0100

> The fixed commit inadvertently changes the error code from ENOTSUPP to
> ENOSYS. Doing so breaks (among other things) probing of macb, which
> returns -ENOTSUPP as it is now returned from mdiobus_register_reset.
> 
> Fixes: 1d4639567d97 ("mdio_bus: Fix PTR_ERR applied after initialization to constant")
> Signed-off-by: Helmut Grohne <helmut.grohne@intenta.de>

You should always generate networking bug fixes against the networking
GIT tree, which had you done you would have seen that this bug is
fixed there already.

Thank you.