Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp613278ybc; Fri, 22 Nov 2019 10:12:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzv3PRWT+qEEInr9oMDWgJK/7oeCMlAv7I1QawHqQIz5/mVt45tqToWzV4T5+OmxMO5qBcx X-Received: by 2002:a05:6402:17f2:: with SMTP id t18mr2718642edy.264.1574446362891; Fri, 22 Nov 2019 10:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574446362; cv=none; d=google.com; s=arc-20160816; b=Dc0QT3T0Pb4MAr8s05ngFzGiEWv+iqQP7maUugPLtc/tcIrJq+mwOGbzywIabXU5pG Y57a0Nf6Fzpik6bbnhxq5kFYOPVET9DSXohZ0JqgT9HUfcNL8KU8vFbjTeClBtDmTkml /y9wBA0KqXAEsSstKfNQIGcfQVRJXKO47+3CFMKq8OzJ8P/1qzh9BCAnQ0srfbEzNRJI VqykEI2R+tkUXgZImUj2XW8vqpCJKkNE1t+GluV04J0lMOXvqSLsTCMfNuVatxHitSGd tqhAHr5lQ/Ur/PNHUhCJq5eBLdXdzPHke2Ys3EGWU0z8vwZ8DkVYUEUzaEe4IVw48rjh VszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=o2E+LMSoF330mRdA/7xG1/2bWIxbMQJdRmBLi1xEWPQ=; b=j1sTeZp7xwylgEqXAxy+ZL1kRSNT0swM/GQ+B9R7ugR3B6PsA7MX2nF2MRZswi0wRT XRcCy3Jh2NB1kZbQL/jDNADs1p2Ic2YLC7bwWARqdpUuCXVHHApAYKAr/dwjYrXGTJRU 2dWdY4dF6BbSmoQurZZaRgwZa2PNNdW9w+n73EkXtjhpK9aQmuwAa16Nvrat8LfB3jxX HsT2Bmcr8VZVYQ7mg9GdGBjXOc45OjXysYBnWrweUwyikPKes97a6TrUgmYJrDzsq7OQ 13ieg6wA0q3fTfRb7oW27tifw7ucD0M7JUDEQKSbksaHkBukLcjFOmffhGWgHBBAgH9V Xqjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si4971063ejh.172.2019.11.22.10.12.18; Fri, 22 Nov 2019 10:12:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbfKVSJx (ORCPT + 99 others); Fri, 22 Nov 2019 13:09:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38520 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfKVSJx (ORCPT ); Fri, 22 Nov 2019 13:09:53 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8ECB715282F7A; Fri, 22 Nov 2019 10:09:52 -0800 (PST) Date: Fri, 22 Nov 2019 10:09:52 -0800 (PST) Message-Id: <20191122.100952.137407515946118851.davem@davemloft.net> To: chenwandun@huawei.com Cc: vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings From: David Miller In-Reply-To: <1574425965-97890-1-git-send-email-chenwandun@huawei.com> References: <1574425965-97890-1-git-send-email-chenwandun@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Nov 2019 10:09:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen Wandun Date: Fri, 22 Nov 2019 20:32:45 +0800 > Fix following sparse warnings: > drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static? > > Signed-off-by: Chen Wandun Next time please indicate _explicitly_ which tree your patch is targetting, because especially in this case the change is only relevant for "net-next" Also, please provide a proper Fixes: tag.