Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Nov 2019 10:36:21 -0800
From:   Paul Burton <paulburton@kernel.org>
To:     Lichao Liu <liulichao@loongson.cn>
Cc:     chenhc@lemote.com, jiaxun.yang@flygoat.com, ralf@linux-mips.org,
        jhogan@kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS:Loongson64:Limit 8259.h by config
Message-ID: <20191122183621.67p7vuvfzhpoldna@lantea.localdomain>
References: <20191122135851.5145-1-liulichao@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191122135851.5145-1-liulichao@loongson.cn>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lichao,

On Fri, Nov 22, 2019 at 09:58:51PM +0800, Lichao Liu wrote:
> Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
> to control whether to include the asm/i8259.h header file.

Generally including headers is harmless - it's quite common to include
headers which might or might not be used, and if nothing from the header
is used then its inclusion simply makes no difference. The compiler will
see the header contents & discard them, no big deal.

So can you describe why you want to add the #ifdef here? What's
problematic about including asm/i8259.h when CONFIG_I8259=n?

Thanks,
    Paul

> Signed-off-by: Lichao Liu <liulichao@loongson.cn>
> ---
>  arch/mips/loongson64/pm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/loongson64/pm.c b/arch/mips/loongson64/pm.c
> index 7c8556f09781..08238a58107f 100644
> --- a/arch/mips/loongson64/pm.c
> +++ b/arch/mips/loongson64/pm.c
> @@ -9,7 +9,9 @@
>  #include <linux/interrupt.h>
>  #include <linux/pm.h>
>  
> +#ifdef CONFIG_I8259
>  #include <asm/i8259.h>
> +#endif
>  #include <asm/mipsregs.h>
>  
>  #include <loongson.h>
> -- 
> 2.17.1
>