Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp656039ybc; Fri, 22 Nov 2019 10:56:48 -0800 (PST) X-Google-Smtp-Source: APXvYqyES3kFqKSTIB9pUj03inIJGin7lBS4vxbuESa1BwLCGqkFx+PqMRt/g8/hD0ANpnTVGnqi X-Received: by 2002:a05:6402:1609:: with SMTP id f9mr3010826edv.37.1574449008333; Fri, 22 Nov 2019 10:56:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574449008; cv=none; d=google.com; s=arc-20160816; b=s5pb5vlADUGGdGL25yXegMCoZGYu5ZjVFSfwBtlpRobj8UPuuxPg2xQlQrenmL8TZb kCHEsKjoXL/bt+YrQ2eYld6/huPBzIAorwJZN/GklkeudTDW4zCuTgtHCU8EiyIQK7qd MMFNNrcA16RPAbjZdMKrl88qDqJl3/RVPi6E7wkx4bvYsY1f3OG9W7ZHBAxBNQp682wI WRtcFojVKpjV+2MPohnXvKIe0oK3qSUzDchyyJfd2DyFLO0ghrp0FBELm5X0gVm1Syw+ BAFsZEVTTYnFQfOpTrWSQTdMApZZEOzPTP5tJ6IZwD6XstFv9Y7z5x2r4FWxvQvOcnZs sWmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=X6rPmQDZwe/5i7ZTCvqZcbNZzoAWqfhhq8dBz2pi7Wk=; b=PFaK5hffVLLODzKNBfHpTPkl7g6skm430RQ0XPUJCbmB733dJWYzRV5N03lRTw63Au jN9pt1/mzhfrYJHss34o0oWKSxUQyhpaxFEpTy0iUerWRjwU/vHGSW3SqK4zFBU8gONE QH8CsRwjrWHYJguZCTRMA/PkOOsAsze4GkHJ3GFfOGA5HlPe4G1BpvfcfBsupPYc1l4B bQfEPaIiYJ4MXS+hGt5u3R1W68p+WtCWkMXj4w4N19+DXYZqUmx4kK9aAnqGpSaT0NQg JZ2YGxJkqjBenHPNFCFN+k0uwPmCI6CyZrY7LT4vpnnviiMmk1XX8OgRA3vUBRUBtTTF mH/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=v5F6MF9A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14si1724618edi.116.2019.11.22.10.56.24; Fri, 22 Nov 2019 10:56:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=v5F6MF9A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfKVSzP (ORCPT + 99 others); Fri, 22 Nov 2019 13:55:15 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:33316 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfKVSzO (ORCPT ); Fri, 22 Nov 2019 13:55:14 -0500 Received: by mail-pl1-f193.google.com with SMTP id ay6so3480967plb.0 for ; Fri, 22 Nov 2019 10:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X6rPmQDZwe/5i7ZTCvqZcbNZzoAWqfhhq8dBz2pi7Wk=; b=v5F6MF9AvTQxk7Vd5aRT1Y9yCCk/Z9IA82/6jCjumROrrWFeFp1LbnUS5FJt9Xc7db NEEbLR70LWuDqes2CfBtQ6aUTKTa3SB2WZDmj2X1TaEa7JG03Ov0oOxccgWiam8ANZ9v Eme8ZIJlZTJNGSlQ2LoRYWSuhJgV+FRdjjdsymttU5qfRuZMpr5S+CfdK9q5V32uuJk9 s7spTGMpIFLp1KaoDmWmCcrrqZNnqsDUpcMkn2PrQZjOT5cArAy/2zeoGmp5XTAGBQTc RAzOzoIri1O2C2TGJS1yJ14UMeJUn/+FRqi0nUY3jgHvmBRTYJ9eptMHcUQ9eczjbpgJ TN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X6rPmQDZwe/5i7ZTCvqZcbNZzoAWqfhhq8dBz2pi7Wk=; b=SKpJVXweCHupFkPP+gaQrVUqp1PiRvR3GFrRAsGA2iqkq2lOB9AzAMZgU2k4nFNhDa O+psjAhBfqJOrNWU+5ST3tF3wQWuVY2QQj6G3obI/dnYTaTfNKh/1ygjYtjgt6YLpBbb n85EFbEhMqi/lPtl8sDUlx5eTwJwxT7E2cT2lgfcBaa6lcArkaV2g7qXmtfFo8T8xA35 5J81CVPzM3iXPws24i7Gk9cbqc4uXgFzvy7IJd3mX3WOSvXwMueuHV7+G2+APz2AtZuk FH4EQADDVaK/d2Kg8oO0oUHyaP1WXxsaf3uSxY64DJWMoWJT4W/R4xVR82YiSSnQ3cyM CouQ== X-Gm-Message-State: APjAAAWhxbX20k8MR4nBmModRA4loWJ7+BVEST4d0m9dyoYfRcz4aYJ2 zBpJYGUy//LhtPBOt1EK1mk66hy92e4= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr16035047ply.279.1574448913595; Fri, 22 Nov 2019 10:55:13 -0800 (PST) Received: from ?IPv6:2620:10d:c081:1132::1126? ([2620:10d:c090:180::835b]) by smtp.gmail.com with ESMTPSA id c3sm8303326pfi.91.2019.11.22.10.55.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 10:55:12 -0800 (PST) Subject: Re: [PATCH] block: Replace bio_check_ro()'s WARN_ON() To: Kees Cook Cc: syzbot+21cfe1f803e0e158acf1@syzkaller.appspotmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180824211535.GA22251@beast> <201911221052.0FDE1A1@keescook> From: Jens Axboe Message-ID: <181810c8-657d-d603-a833-215f753be5be@kernel.dk> Date: Fri, 22 Nov 2019 11:55:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <201911221052.0FDE1A1@keescook> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/19 11:53 AM, Kees Cook wrote: > Friendly ping! I keep tripping over this. Can this please get applied so > we can silence syzbot and avoid needless WARNs? :) I'll get it applied, I did see syzbot complain about this again. -- Jens Axboe