Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp669369ybc; Fri, 22 Nov 2019 11:08:45 -0800 (PST) X-Google-Smtp-Source: APXvYqzwaK0csIN0CBw88lI64dEqCdgFZXQyIFOZcf2g52bNTeqO8DZRRu1MV5e4KWCl7lhxC+ZC X-Received: by 2002:a17:906:3019:: with SMTP id 25mr23895840ejz.280.1574449725649; Fri, 22 Nov 2019 11:08:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574449725; cv=none; d=google.com; s=arc-20160816; b=o08VHQu7kBUqqk3sYtHG5VQA5xB9PncB9+4nX3HWqAlKWxP0EGCRhJV0m0AZ6ar/c+ CtBJsb4p8X9IY6jKNWagjz7nfMP4dkH4VQa529DjvY2CsAGl8w0JkiceVk0ePx4iQOkD 6M1HHP/stu2x+A6wO59t7/69R0eZmqgrO8lteqLme6FQcPc96x+t1zgI1Y+HDjWzBOQo UBopM3gh+ukCz/6vLKtxz0tvEZGeW6IxuGczfOrzFH0i/Qv5ytBKcoEXI39nqEeTF+2c Mj4vNuXBdt3S03ES7aj59ydzb3aQ5zYkfoCxsvmVD1bMqmd6YwK2h1xLOmEA2z/kXjiV sJDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qiY03cWkKvWU8uOxj3HAT7UHKA03ikQ/FO2WIvS4EWw=; b=tZEOBlCs9Yn0pil6JuLwuzztVhGxqbIISnTxzf43RIhnCTP0lCfK69njxmAm7l/PZq tXf8rwtOvAiRnA//RGhc224nVVHLxhn2glE24kdRrBztKVRGgmXraW//e/jviWGtvh3h A4Mk2PeTLNc6jICJirG2YeI1ihJujAslgfyF6o2W2+VtFKdaO+FTSttbVv2FbxmpH/nC eha3UwG+24Mg13S7lJN8iqqDV9q90x0d5Y7zIzSfvbSbcBIe8PnvVrUZ8cWBlinMvJGT AsvL5Zq5PmX9IzmjJZlbVD6Tu+yNtfxm81FmQC07RRTuIPNgOuUYqvgTyUaRfR7p56f4 f0nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HDPXvtPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5si4937335ejw.281.2019.11.22.11.08.18; Fri, 22 Nov 2019 11:08:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HDPXvtPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfKVTHJ (ORCPT + 99 others); Fri, 22 Nov 2019 14:07:09 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53710 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbfKVTHJ (ORCPT ); Fri, 22 Nov 2019 14:07:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qiY03cWkKvWU8uOxj3HAT7UHKA03ikQ/FO2WIvS4EWw=; b=HDPXvtPMmErfbxSjo4gpGLhFO AKXfAQJ4M1Mdd//OfGFHdmLefRtXxrKQ5rKbLSZ8JZ2f7Kswj4JlwbdQdFBQtu7BnlL/vm9gGkQT+ KaKkNX+9WhX7ugGxgPQLPOm9iW/xbtZYtWczgJgbMZxQ7cJlFRRrGnH7OqEKp0eYcnIaEAYEUURm2 40AlNUX9b101r0F8itT5mgBh+HB/Jht5kTS/wKUkny6kSSDWtKDt7g0mhL+DZnRZiFhVgezSrHSSV 3MEv1vxDpWLAXrWKr8O6H6zFiFr7C+rg8Xb+lztSKH0llurL8+2PqwfCOMq62cwX91HEQ66rgCtni YuyDbGV0A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYEGp-0000a5-5q; Fri, 22 Nov 2019 19:07:07 +0000 Date: Fri, 22 Nov 2019 11:07:07 -0800 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , syzbot+21cfe1f803e0e158acf1@syzkaller.appspotmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Replace bio_check_ro()'s WARN_ON() Message-ID: <20191122190707.GA2136@infradead.org> References: <20180824211535.GA22251@beast> <201911221052.0FDE1A1@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201911221052.0FDE1A1@keescook> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2019 at 10:53:22AM -0800, Kees Cook wrote: > Friendly ping! I keep tripping over this. Can this please get applied so > we can silence syzbot and avoid needless WARNs? :) What call stack reaches this? Upper layers should never submit a write bio on a read-only queue, and we need to fix that in the upper layer.