Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp695942ybc; Fri, 22 Nov 2019 11:35:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzcRa3qY7coWiTJTP+oxcv8cyH20h5q8HiDDeDo1F6D6zx/d58DbqQ7FVCpTZpa9/9gslzB X-Received: by 2002:a17:906:4409:: with SMTP id x9mr24026643ejo.236.1574451328166; Fri, 22 Nov 2019 11:35:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574451328; cv=none; d=google.com; s=arc-20160816; b=w72fg9frVNssdiBOCTBLRtM33Z7hwaSTrkw5KSC/xC3SEYLdGIvZUdjfiSgUD0lJQc Xf3RmJWIHRhCh+nB48Nnhllh7Z7mMq5Skgkie4Z3ZabwJ0Ah4sD4w6n1J4dboIrTeUul oJBOz9YjS4MAtDfYVOScY2Ki/lSv/k6scWaRvcg3g6g+Z1lxlKA4eRLqpRcQro0XpOAo tszer5QnG1/LHJPmbEAwhVG8C9C51q0hE/j/NofbS9ElGk+pyXxVsepbaTzd4qdLyarY A4VOVuI0BuCAkYadaHGcKAaeaMhIpVkKtTSqTRyVO9tIuuj6bkW/E6fDVSjW0sfN3yO1 TKHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=MHDX6AdLLIWuuwMa7ws4so1QjqLZd2fQo8w152Jy6bY=; b=UzL+Xum6gssBMVIeew6k2YJlKmf5VSMGpxnS9zSUCyL8W/+SF/5l63YU2eiIoDBJ0w xoGuKtJcXVXQwzud8vy0MKELBFTHvBvQBK8sGAAzg7FyUI/MIDGNN3RxqxhwjXme715l a/xIcPzrja85j4xqecmVWTM22DfuGycT3/mzhsV9nB08z1Tgll0u70AsL5/7pKdGmbmd 9NL8xpcTImX7svsH4LT5VNQ+HX6rCZTVjRqiDTU0SM3YyTmBT78jvCDUNisTXuNaUORB a8r2mgKJrhBs2Lmr63Epur6p6qlq4bTWseoGEy9jO/FNU5mWNUOjagLIl5Hm4ZtAue5B t62Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nPoSoT4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si5058515eju.48.2019.11.22.11.35.04; Fri, 22 Nov 2019 11:35:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nPoSoT4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbfKVTbv (ORCPT + 99 others); Fri, 22 Nov 2019 14:31:51 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:42871 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfKVTbv (ORCPT ); Fri, 22 Nov 2019 14:31:51 -0500 Received: by mail-io1-f66.google.com with SMTP id k13so9294129ioa.9; Fri, 22 Nov 2019 11:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=MHDX6AdLLIWuuwMa7ws4so1QjqLZd2fQo8w152Jy6bY=; b=nPoSoT4aW3Ehi2l0eD9o60SzrhXZxiG2uZ1RF7HNBVWBjxNcB6GE1fI9W1I7GhJtCT 6fM+HttOGDrIXEIVYDXtCQMOPC2HzeAmeevj7vBwWgRgCPjO/roikQPeko51EeFQvcYC sBg1W+HvZhA7tRWrxaPNABHStJs3MBqZYipcDVJptxFHoeH2ek3FIMSvQGLxy6oFzheP Fj6pvstzbt/xXK+CLPDxo8uG95kKMTbTHQ3rVBB7zBhszLy34X6cTc75wk8U9WVrEVA9 9CHrOwXHl/EqcVXcUG4BX/xn90/1k6MvMrWTAoGbeQYahZ7UCFqtUYiajE4nXLk1Obs0 l2ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MHDX6AdLLIWuuwMa7ws4so1QjqLZd2fQo8w152Jy6bY=; b=EV6L8mwSNCGRDx2qhxOVKPYsyQLBgSaKrGGxU7iNPgkUjZNCeqhnGGCeQLOSDDGSb2 VFR6LpovD79Y6hOKuT0stnsHtm/Hjkf9L3JGLU4G8DGRiCpF3V2MiCq9Hs6jph2/pdnX nfpXIfizunviR9RAnXRYM/TsBKEM6D/YxkgNbaW4DQNmUxxNc9HZryUUEidlWqvhbnWP R+CjcrlpDmxzDwORa+xa+ENnuTKppT1XAzmQ4lNOEbO7fraBA4+897bXxRY4+Mc6sIYR q3/PxtUK35b4k3pm9HuepvyDELXEy8LFjoYuA8TP84tz7hubEmUdNMJWGLuOU8fobHYl BJHw== X-Gm-Message-State: APjAAAWJhfuwpZ1XbQ4dDQ7ctz7+g44a0mYqT12DzQChtO52frqbLEq/ PP6H3q7tcFHlG2fttjUKYQE= X-Received: by 2002:a5e:c010:: with SMTP id u16mr14269465iol.275.1574451110240; Fri, 22 Nov 2019 11:31:50 -0800 (PST) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id y8sm3095338ilg.47.2019.11.22.11.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 11:31:49 -0800 (PST) From: Navid Emamdoost To: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: emamd001@umn.edu, Navid Emamdoost Subject: [PATCH] PCI/IOV: Fix memory leak in pci_iov_add_virtfn() Date: Fri, 22 Nov 2019 13:31:36 -0600 Message-Id: <20191122193138.19278-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the implementation of pci_iov_add_virtfn() the allocated virtfn is leaked if pci_setup_device() fails. The error handling is not calling pci_stop_and_remove_bus_device(). Change the goto label to failed2. Fixes: 156c55325d30 ("PCI: Check for pci_setup_device() failure in pci_iov_add_virtfn()") Signed-off-by: Navid Emamdoost --- drivers/pci/iov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index b3f972e8cfed..713660482feb 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -164,7 +164,7 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id) rc = pci_setup_device(virtfn); if (rc) - goto failed1; + goto failed2; virtfn->dev.parent = dev->dev.parent; virtfn->multifunction = 0; -- 2.17.1