Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH v6 3/5] locking/qspinlock: Introduce CNA into the slow
 path of qspinlock
From:   Alex Kogan <alex.kogan@oracle.com>
In-Reply-To: <dc31b3ea-1b03-16d3-1a03-a0a7ad1729d2@redhat.com>
Date:   Fri, 22 Nov 2019 14:52:23 -0500
Cc:     kbuild test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux@armlinux.org.uk, peterz@infradead.org, mingo@redhat.com,
        will.deacon@arm.com, arnd@arndb.de, linux-arch@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
        guohanjun@huawei.com, jglauber@marvell.com,
        steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
        dave.dice@oracle.com, rahul.x.yadav@oracle.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <78BB046F-700B-4108-923B-0FC5D7550385@oracle.com>
References: <20191107174622.61718-4-alex.kogan@oracle.com>
 <201911202212.CdyX1gua%lkp@intel.com>
 <B1A1B09F-C44E-45F7-80EB-09E30AEFD358@oracle.com>
 <dc31b3ea-1b03-16d3-1a03-a0a7ad1729d2@redhat.com>
To:     Waiman Long <longman@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Nov 22, 2019, at 2:29 PM, Waiman Long <longman@redhat.com> wrote:
>=20
> On 11/22/19 1:28 PM, Alex Kogan wrote:
>>=20
>>> On Nov 20, 2019, at 10:16 AM, kbuild test robot <lkp@intel.com> =
wrote:
>>>=20
>>> Hi Alex,
>>>=20
>>> Thank you for the patch! Yet something to improve:
>>>=20
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v5.4-rc8 next-20191120]
>>> [if your patch is applied to the wrong git tree, please drop us a =
note to help
>>> improve the system. BTW, we also suggest to use '--base' option to =
specify the
>>> base tree in git format-patch, please see =
https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__stackoverflow.com_a=
_37406982&d=3DDwIBAg&c=3DRoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=3DH=
vhk3F4omdCk-GE1PTOm3Kn0A7ApWOZ2aZLTuVxFK4k&m=3DBxEt1232ccGlMGDinAB0QAUaTFy=
l-m5sp4C-crHjpoU&s=3DOzzQqg4fTDV55X-y4vbnGeXoJaPHSvO_EfrUQnMVRHc&e=3D ]
>>>=20
>>> url:    =
https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_0day-2Dc=
i_linux_commits_Alex-2DKogan_locking-2Dqspinlock-2DRename-2Dmcs-2Dlock-2Du=
nlock-2Dmacros-2Dand-2Dmake-2Dthem-2Dmore-2Dgeneric_20191109-2D180535&d=3D=
DwIBAg&c=3DRoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=3DHvhk3F4omdCk-GE=
1PTOm3Kn0A7ApWOZ2aZLTuVxFK4k&m=3DBxEt1232ccGlMGDinAB0QAUaTFyl-m5sp4C-crHjp=
oU&s=3DuE7ZeYXOFiu09PUVjnCntEe2rR5x_QxS6dEW9twpfok&e=3D=20
>>> base:   =
https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__git.kernel.org_pub_=
scm_linux_kernel_git_torvalds_linux.git&d=3DDwIBAg&c=3DRoP1YumCXCgaWHvlZYR=
8PZh8Bv7qIrMUB65eapI_JnE&r=3DHvhk3F4omdCk-GE1PTOm3Kn0A7ApWOZ2aZLTuVxFK4k&m=
=3DBxEt1232ccGlMGDinAB0QAUaTFyl-m5sp4C-crHjpoU&s=3DaAKxuXc_c7OF0ffioQfVsIB=
6H-4Sd9PYxSM7kurm2ig&e=3D  0058b0a506e40d9a2c62015fe92eb64a44d78cd9
>>> config: i386-randconfig-f003-20191120 (attached as .config)
>>> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
>>> reproduce:
>>>       # save the attached .config to linux build tree
>>>       make ARCH=3Di386=20
>>>=20
>>> If you fix the issue, kindly add following tag
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>=20
>>> All error/warnings (new ones prefixed by >>):
>>>=20
>>>  In file included from include/linux/export.h:42:0,
>>>                   from include/linux/linkage.h:7,
>>>                   from include/linux/kernel.h:8,
>>>                   from include/linux/list.h:9,
>>>                   from include/linux/smp.h:12,
>>>                   from kernel/locking/qspinlock.c:16:
>>>  kernel/locking/qspinlock_cna.h: In function 'cna_init_nodes':
>>>>> include/linux/compiler.h:350:38: error: call to =
'__compiletime_assert_80' declared with attribute error: BUILD_BUG_ON =
failed: sizeof(struct cna_node) > sizeof(struct qnode)
>>>    _compiletime_assert(condition, msg, __compiletime_assert_, =
__LINE__)
>>>                                        ^
>>>  include/linux/compiler.h:331:4: note: in definition of macro =
'__compiletime_assert'
>>>      prefix ## suffix();    \
>>>      ^~~~~~
>>>  include/linux/compiler.h:350:2: note: in expansion of macro =
'_compiletime_assert'
>>>    _compiletime_assert(condition, msg, __compiletime_assert_, =
__LINE__)
>>>    ^~~~~~~~~~~~~~~~~~~
>>>  include/linux/build_bug.h:39:37: note: in expansion of macro =
'compiletime_assert'
>>>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), =
msg)
>>>                                       ^~~~~~~~~~~~~~~~~~
>>>  include/linux/build_bug.h:50:2: note: in expansion of macro =
'BUILD_BUG_ON_MSG'
>>>    BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
>>>    ^~~~~~~~~~~~~~~~
>>>>> kernel/locking/qspinlock_cna.h:80:2: note: in expansion of macro =
'BUILD_BUG_ON'
>>>    BUILD_BUG_ON(sizeof(struct cna_node) > sizeof(struct qnode));
>>>    ^~~~~~~~~~~~
>> Consider the following definition of qnode:
>>=20
>> struct qnode {
>> 	struct mcs_spinlock mcs;
>> #if defined(CONFIG_PARAVIRT_SPINLOCKS) || =
defined(CONFIG_NUMA_AWARE_SPINLOCKS)
>> 	long reserved[2];
>> #endif
>> };
>>=20
>> and this is how cna_node is defined:
>>=20
>> struct cna_node {
>> 	struct mcs_spinlock	mcs;
>> 	int			numa_node;
>> 	u32			encoded_tail;
>> 	u32			pre_scan_result; /* 0, 1, 2 or encoded =
tail */
>> 	u32			intra_count;
>> };
>>=20
>> Since long is 32 bit on i386, we get the compilation error above.
>>=20
>> We can try and squeeze CNA-specific fields into 64 bit on i386 (or =
any 32bit=20
>> architecture for that matter). Note that an encoded tail pointer =
requires up=20
>> to 24 bits, and we have two of those. We would want different field =
encodings=20
>> for 32 vs 64bit architectures, and this all will be quite ugly.
>>=20
>> So instead we should probably either change the definition of =
@reserved in qnode=20
>> to long long, or perhaps disable CNA on 32bit architectures =
altogether?
>> I would certainly prefer the former, especially as it requires the =
least amount=20
>> of code/config changes.
>>=20
>> Any objections / thoughts?
>>=20
>> Thanks,
>> =E2=80=94 Alex
>>=20
> The easy way out is to restrict NUMA qspinlock to 64-bit only. There
> aren't that many 32-bit NUMA systems out there that we have to worry =
about.
>=20
> Just add "depends on 64BIT" to the config entry.
Ok, will do.

Thanks,
=E2=80=94 Alex=