Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp757776ybc; Fri, 22 Nov 2019 12:36:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxtqzCCStfM3FZ9Id0Xd87AamVaFGrxgNoiuqaFIejNG16/OU8eXYUfQFRe4vwh3HfVw+8c X-Received: by 2002:a50:cc07:: with SMTP id m7mr3598958edi.146.1574455019582; Fri, 22 Nov 2019 12:36:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574455019; cv=none; d=google.com; s=arc-20160816; b=0gW3H740z6ATekKHm/W5r4lwuco/sMIUfODyKzT6x+4aX7joQJiRCJqWPmkPHvqFen qccxnfH1pKeTr2lIv3A538PiJXAIg3yRpQFTSINFYOWlb/0A7oeSEga1zhGG83a+3JBx uzK+IfMtcdM+E+Fmn+q0gihto16Cg0cid3DvHyaZBnWZ8t0ENPysPtOBpWUiu8pg+Iht L2GFTO6yH0mjLZirFYVreSUZPMWk3rWgUQLkp07+VqNf9mlG3s0MwM+KaplOMQCb/f2Y Kp1dPIS65Vg9Lg18OgtsgwE0BhGMe7tV14F6XjtExsbdRKCXmZWX5MBMjQ0IDhESeRaw iIpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+Yg2/Hm5cj1++a0Hcu01FV0/uqXnkXadO3bz6Dd3Kiw=; b=keFXSvvbfXmN4JIAlTFyunx2kY64b0MrgSJKvmyai4vAf9bfVjQqspizqJptxt+zAj EW/VQ6yBOMmoyVJb3dRVrVWazzf/au18G4MdRilkqAodaaL3GzdfU3PPos7e8lcRrq1t 2EuZ+DWFwWCnUMit2Vt99DzWZ5GhHMQMlJHNfNo4D19cvzQPyBqK50B3Zx5PGXTUnLfp +xUvk9kKiOEODtm0/7P8SqZ/TKeZNPz1zhm/1jHqFx51HCk7Tffp5BKAYfzB0YUCfmwo 5DgX6+2m6JIUxm1WsU1CTjWPSPCfKBuSkOcEkG8aOsPrk+IqTxckpzJCzKxU81Q8gFQ5 QR7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=m+N+WXsh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t18si5140134ejx.354.2019.11.22.12.36.35; Fri, 22 Nov 2019 12:36:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=m+N+WXsh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbfKVUcU (ORCPT + 99 others); Fri, 22 Nov 2019 15:32:20 -0500 Received: from merlin.infradead.org ([205.233.59.134]:43604 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbfKVUcU (ORCPT ); Fri, 22 Nov 2019 15:32:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+Yg2/Hm5cj1++a0Hcu01FV0/uqXnkXadO3bz6Dd3Kiw=; b=m+N+WXshWpx+s7Wc8ziZvesKW tEdUpEx+9YOIXbTLZTQ+Y3YEBkxaTGqap4wjjb09MBT4LHGRJi/kv464oRqzU17dHHcLjaqZss/Xs hoJqbQiE4Yfpoh5D3s8qPLQp3H9wfJFcHOIGYYhr/wtHsJKwlAN1uJoOJFJHLinY53jQ3nKKDaQKE STjwD14ik9HuyPF76d+KL6im0oskgRNVmmeFO0yMsnIZGpXTMTDeO0SG4FtIlkts+ebz0BjsLhAIy EgBHpdLh2QPBkesPGS7wpWS1SCaAq/3KgsXCHN+ELZKmJw8FlBcNGELBuxS7Yj6Hc091HnCYq7uAX cSM0A4sSg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYFbD-0006Gv-82; Fri, 22 Nov 2019 20:32:15 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 90362300565; Fri, 22 Nov 2019 21:31:02 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 0BC2F20321DB0; Fri, 22 Nov 2019 21:32:14 +0100 (CET) Date: Fri, 22 Nov 2019 21:32:14 +0100 From: Peter Zijlstra To: David Laight Cc: 'Andy Lutomirski' , Ingo Molnar , Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Tony Luck , Ashok Raj , Ravi V Shankar , linux-kernel , x86 Subject: Re: [PATCH v10 6/6] x86/split_lock: Enable split lock detection by kernel parameter Message-ID: <20191122203213.GF2844@hirez.programming.kicks-ass.net> References: <1574297603-198156-1-git-send-email-fenghua.yu@intel.com> <1574297603-198156-7-git-send-email-fenghua.yu@intel.com> <20191121060444.GA55272@gmail.com> <20191121130153.GS4097@hirez.programming.kicks-ass.net> <20191121171214.GD12042@gmail.com> <3481175cbe14457a947f934343946d52@AcuMS.aculab.com> <397239502dad4bc3819c49c7d569c70c@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <397239502dad4bc3819c49c7d569c70c@AcuMS.aculab.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2019 at 09:46:16AM +0000, David Laight wrote: > From Andy Lutomirski > > Can we really not just change the lock asm to use 32-bit accesses for > > set_bit(), etc? Sure, it will fail if the bit index is greater than > > 2^32, but that seems nuts. > > For little endian 64bit cpu it is safe(ish) to cast int [] to long [] for the bitops. But that generates the alignment issues this patch set is concerned about.