Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp21032ybc; Fri, 22 Nov 2019 15:17:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwftRYBbeUqR5gICe9ql/BcvTJHysgkm6wtZic16aq2ynwA2avsC5pw3q3JHypjpLRKUkWG X-Received: by 2002:a50:c191:: with SMTP id m17mr4357232edf.259.1574464675777; Fri, 22 Nov 2019 15:17:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574464675; cv=none; d=google.com; s=arc-20160816; b=lDwNvqkflJ8GlEL250IJMnPuFJWel80shcEZJko0WZDb2pwuE+HpmKO+m9eDZo5gl5 mftGgUPJPDSRRqbHT9DfCRGx3nCavpgKc/su63fc02gylFDG9mGVeiRjGDx7PkmvFtd0 bhTw7koC626KHJhzikppNsDLKViunfW4eNtwyLzW66D9bFj0y586NXMGCLbZWs29iSsN CMuyleF5kDP2KK6IcefRFkLv6T23ubMiRea5RPgEGRUpDOmK+FmzBpGvop15VEP6tA7/ P8Udu3uIJqhOIqjeHC0qbtYMM9nmy7LOtVBnY7A9CgoDt/4bHPiMSU49QGanxCsivOdq aOdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=h66orNIRlxipn9OanQ0e7UoO0EZyQRcJCeSlCInnFok=; b=gOo3NynQD2suow1eJDheyCza0yfMIZWJoB7eho4zMLSprcyvSjSY4YC1zVoDEpgoyQ mAZQb/Zp05dEhR6k+5dnVfCmEia+BAso/+J9ZAjvC7ECT/5PiL+2+/qwfd5MwkPwmAAR ODBW+Kwec+NvqEl01rF6vwkKGZ+oFHNM1SsLdI1suxfcnqZMNXA0v3dg3X+RB1HriSOm lrg5sWH088A2lBQImIQnoVtHzAIOl61Wg3sXH6W5wwq6E22jQar6k5ObiVhChyfsNi2p usz61htsancyZVTpzQQL4MktYzcvKbJjzc/+rSeV3h1HSwIaxonFCw0zgomKehPOPW/z YaOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ctI5nV54; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18si6734100eda.291.2019.11.22.15.17.31; Fri, 22 Nov 2019 15:17:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ctI5nV54; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbfKVXQd (ORCPT + 99 others); Fri, 22 Nov 2019 18:16:33 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:22141 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726089AbfKVXQd (ORCPT ); Fri, 22 Nov 2019 18:16:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574464592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h66orNIRlxipn9OanQ0e7UoO0EZyQRcJCeSlCInnFok=; b=ctI5nV54BuKgzA8CYkGiHvKmkoJm5K2A+NKdIck3ZWQmddHrBKvfzpe0TcAHnDCll9xpOq /XEYAElft3asYjFy4MZOYaSncdgRdphEuHv12tySO+6pnehwwVXDyBWqbbUWEmBeA/Gedq x77IUNCZxuwdQ9xnRNNRsQO9KUCo9FE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-nsI8QOLrMtq3qYavP0mS_Q-1; Fri, 22 Nov 2019 18:16:31 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CC94100726A; Fri, 22 Nov 2019 23:16:28 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-34.bss.redhat.com [10.20.1.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21F8B19C4F; Fri, 22 Nov 2019 23:16:24 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org Cc: "Daniel Vetter" , "David Airlie" , "Maarten Lankhorst" , "Rodrigo Vivi" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Imre Deak" , "Jani Nikula" , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , "Chris Wilson" , "Joonas Lahtinen" , "Lee Shawn C" , "Lyude Paul" , "Maxime Ripard" Subject: [PATCH 0/5] drm/i915: eDP DPCD aux backlight fixes Date: Fri, 22 Nov 2019 18:15:58 -0500 Message-Id: <20191122231616.2574-1-lyude@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: nsI8QOLrMtq3qYavP0mS_Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I recently got a ThinkPad X1 Extreme 2nd Generation for fixing some issues on, and noticed that out of the box the backlight doesn't work. Along the way of fixing that, I found a few issues with how i915 handles DPCD AUX backlight control and fixed them. Now I've got working backlight controls, hooray! Note that this patch series also enables DPCD aux backlight control by default based on what the VBT tells us. Lyude Paul (5): drm/i915: Fix eDP DPCD aux max backlight calculations drm/i915: Assume 100% brightness when not in DPCD control mode drm/i915: Fix DPCD register order in intel_dp_aux_enable_backlight() drm/i915: Auto detect DPCD backlight support by default drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel drivers/gpu/drm/drm_dp_helper.c | 4 + .../drm/i915/display/intel_display_types.h | 3 + .../drm/i915/display/intel_dp_aux_backlight.c | 167 ++++++++++++------ drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- include/drm/drm_dp_helper.h | 8 + 6 files changed, 134 insertions(+), 52 deletions(-) --=20 2.21.0