Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp733420ybc; Sat, 23 Nov 2019 07:20:06 -0800 (PST) X-Google-Smtp-Source: APXvYqwfdRGhrEINvN5C86tFGlK/zcq3T/cRgH3A0sTcADauwywpHrgrbnK9QMNZcLHE5umIR/kN X-Received: by 2002:a05:6402:17e7:: with SMTP id t7mr1355524edy.114.1574522406526; Sat, 23 Nov 2019 07:20:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574522406; cv=none; d=google.com; s=arc-20160816; b=041Nbym36MCLiwX/lPkqr7ovWj9vZl8y47NbDcrDVGk2XMPuO1zpQYU/LPbu6Alw3u A5ErbU1GbNSLswOaSzlBbmm/YAUmtyNETjJfFVsmUkC6A3nuwEP/7keupyb6IqbyhaVC Ohyr4arq9f2+N/7QweMwkke6wBI3A9xS+cO+F2V6tkhVvZnmrd/qBpntFXluSHbKqY+G lcIXgATsvNU/jEY4SFtn+kOnB525oDHrEzib9PfMd0HHFNPpGoTwn/1XOu7hD6a3S3Pe +GSNfYEPW7O0NtuiM0i91MX5mRjA7xctUpTxOkpCyj7Gji259ctpNAzAcOpxrTLBIwtG LgDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dFed9VqpsJKafs4auYjqVCiB2JZMUoL2P/uWCdp5l5Q=; b=sZZPNvPYrjmTrWUMmU4o0AghhtdsZEK2s8OKi8fyUadyso/qkMKt/OjIwsWaLLRJhz EaeUN+Ke8K2STtROCo6BpD+WovP9F13FUPMdqnPfbzx/s6DHh3I/5Qkuq8kXkNLDH7Go MhWOCnB8ZRkTlula+1OKvMRPRTNwMgIv2pCOyYDgePjLC/aiY9W9D2qncVrY2ZD35BiI 6mT3tyFaqJzUGe6hx2n0C+M4a86dI3zff6ZeQuJOYG7FxbU7aMnzmPBh2bYZUBarT4s6 Yo3Y3zv6vhWxFEtLLjvxkrejchu+gkp6zHfg5Df6b7SZypVZSOS7a5NaJi56VQPYC/7Y alYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s5jME4Kl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25si922492eji.283.2019.11.23.07.19.05; Sat, 23 Nov 2019 07:20:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=s5jME4Kl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbfKWPQv (ORCPT + 99 others); Sat, 23 Nov 2019 10:16:51 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:35568 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726704AbfKWPQv (ORCPT ); Sat, 23 Nov 2019 10:16:51 -0500 Received: by mail-wm1-f65.google.com with SMTP id n5so853806wmc.0 for ; Sat, 23 Nov 2019 07:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dFed9VqpsJKafs4auYjqVCiB2JZMUoL2P/uWCdp5l5Q=; b=s5jME4KlROGZt+v99F8rHGB4q5F574j8yIuMkOLNP3orVMGMgvDhzbh43mm6EWJsrP gLnQM/bQ2lxwUP6RhPwXRaIK5x/V+73jG8qTjOOSQmua5yY8ImMouZhjYK4v1hiHGIBy i8+4ZmlLayz0DP50sOFtd+GCdFVJh3eoWerV0D77GNUTwxS4hjVHrXM+fSXt/82piM3x BH3edRluBQo4LxXahRLiShZz+EItaSeBkbewUDLisRKhjcRVJvVBGy6rOdG/4CGEJxHJ PFQyykDM4RliuUz8JePMCw0uYlCGHC+SMxKiJQbY+RoDoBXef4QjkKBQ7VaIv2zFuXRa m9iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dFed9VqpsJKafs4auYjqVCiB2JZMUoL2P/uWCdp5l5Q=; b=rf+bsP51sXUsKYPP7r28I0wUv8gDRdW7iTsFPkqRsJ1jIz6o4Iv09Lh9xjv2qWZg7n QqHKKs0AIQIyuDsQx0d7/mYfR8jkjfE+9yCa5vTP+ZQnlPcFYrYoh0XAwX3/j0hwvgzl K3aGVVaP1ADeU8fuAqGh5NEB7R4mntX+GZm5DL+C7I7K9FGxZQUAKmv0UTcX3+w6kt5D 1DI1m9sxfWJ5fF2FLlQC4D1sOyS+2MJiTKEIP7qCl7I9Z9Zu6gMPcn95r1KDuRNx8T8v 2jOqQAExaaNPnXS3U3Kt2FqC6Y9WTja12DMK5JMX0ti7AhrV7T8LOxH9bQ5+ZbJqcugW bbVA== X-Gm-Message-State: APjAAAUDjgzVPhi5GxSBSQvYy5FdVF54VPt2PUIH2OYi2lp/xS/mUHuz U+2iK5Yg9Z6FhB5RUsa6LVA= X-Received: by 2002:a05:600c:2549:: with SMTP id e9mr20859986wma.177.1574522208846; Sat, 23 Nov 2019 07:16:48 -0800 (PST) Received: from localhost.localdomain (dslb-092-073-054-228.092.073.pools.vodafone-ip.de. [92.73.54.228]) by smtp.gmail.com with ESMTPSA id p25sm2126311wma.20.2019.11.23.07.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2019 07:16:48 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/3] staging: rtl8188eu: remove return variable from rtw_pwr_unassociated_idle Date: Sat, 23 Nov 2019 16:16:35 +0100 Message-Id: <20191123151635.155138-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191123151635.155138-1-straube.linux@gmail.com> References: <20191123151635.155138-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function rtw_pwr_unassociated_idle returns boolean values. Remove the return variable ret and the exit label to simplify the function a little bit. Return true or false directly instead. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c index 8e99e10c1fd4..c4f58507dbfd 100644 --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c @@ -201,21 +201,17 @@ int ips_leave(struct adapter *padapter) static bool rtw_pwr_unassociated_idle(struct adapter *adapter) { struct mlme_priv *pmlmepriv = &adapter->mlmepriv; - bool ret = false; if (time_after_eq(adapter->pwrctrlpriv.ips_deny_time, jiffies)) - goto exit; + return false; if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE|WIFI_SITE_MONITOR) || check_fwstate(pmlmepriv, WIFI_UNDER_LINKING|WIFI_UNDER_WPS) || check_fwstate(pmlmepriv, WIFI_AP_STATE) || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE|WIFI_ADHOC_STATE)) - goto exit; - - ret = true; + return false; -exit: - return ret; + return true; } void rtw_ps_processor(struct adapter *padapter) -- 2.24.0