Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1297093ybc; Sat, 23 Nov 2019 18:31:10 -0800 (PST) X-Google-Smtp-Source: APXvYqwrlJme28YsOpejnlvSROSE8OeQVZY7ofogd36QNqQayZyZiVrw7uiJAoh5Y9p8r2rtflYE X-Received: by 2002:a17:906:ecf5:: with SMTP id qt21mr29431881ejb.295.1574562670389; Sat, 23 Nov 2019 18:31:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574562670; cv=none; d=google.com; s=arc-20160816; b=szaEoJXrxEYPUFgiC8UauHghW1DBAXs9p9GPYFgcV/kVAkZ4fFARMl9UhL0p40y/dB xEHp7Aw1a53G97YfFpz8oehm7qXHahQt+WMGQ8UNhmpDwZbTGxt91/ojg7ZtsBhxA5cR nnqrqOUU+tIXnO10qV7MnycGLVBwELZpi2rI6K3ApJppo6MfaOqWeijrC24unuJ737qR T1ZIsVXNxiIqFcToDm2t/JMKdgU2W9GjoXZHhvRfFj38Z9BbQcoBY/gBkrdxYsuTPwYy kUQJqdwstn0TKmqPVVNon+cYgzRDFNxN2QDyvZM6MYW93jXnyy8N4Q6a/qJ+hAxhwqUY LPAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=O1nyYlECjp0BHoEkdlX1u+EmoR7HXi9s61iX1ye0QNg=; b=syOoMnaH55YRB9SwBkzK0yEHEXAeFRs0pL6AqPufHdn1A8zOf+mPsIWIbHqNx3onk7 zbB90GeuHh1eu5HFmLs3CyjgBLBvBWXiY0fSUnPLHBfFCKPvQfBr/rmjwAfJl9FVMWw+ g8sDDtLV/+fw9l8jFYvuNCJRvyrmndLJ+iExdG6t4n4Q3WLhnER4+019sV7ROzETVc0a wQQBKaO+zp6qWDxtupzApF3JZMVRIHpVCKqbLOgDw47euPDgOmOVDh3xXF2pAlq+Iehj hSovCvUodsuow9Csl/LRVqLkNNJ/VSUu0YcHB3FJy0wpbhBhnD07tiIZ3pDFmO4JzcES CPPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=F9Q1zyQn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p20si2138100edi.252.2019.11.23.18.30.33; Sat, 23 Nov 2019 18:31:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=F9Q1zyQn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfKXCZv (ORCPT + 99 others); Sat, 23 Nov 2019 21:25:51 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43553 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfKXCZu (ORCPT ); Sat, 23 Nov 2019 21:25:50 -0500 Received: by mail-pl1-f196.google.com with SMTP id q16so690856plr.10 for ; Sat, 23 Nov 2019 18:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=O1nyYlECjp0BHoEkdlX1u+EmoR7HXi9s61iX1ye0QNg=; b=F9Q1zyQnHoqvRkvUyxc75tvx/7Hc0KdxQCXE7E7G2mtU0C++RNydvVcevUBNiwtB76 3yAaNcEU0c+0KYjgoCVe4oazerk5qMtWsTEvzaD0YuvcGyr/B53EWVw3o1CPF7e0zfH7 XO+dIhDZIAVuv/OlTG2r52gznYaXCPTPD+JtXVOX38kLK4Ko/azPep9mX09We+f7yr/5 21G3Sg+WT62U7R0Ul4WeM+yAoazH0qz7id3M3LZUeHfV2mdknVbNfjIJ3CcSqkJqYZwF 7LPO4r1txTKglogpFj0dJ7h/9YpxxO6qhvwb179kCLhtQAJg6H+et3QTmTdUz1xlJMLT vRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=O1nyYlECjp0BHoEkdlX1u+EmoR7HXi9s61iX1ye0QNg=; b=LC67zOl4P2b8/mhZNzxpTzglm9bfX1Gu9vBTtHRQn+ME467vTqRibqZ6a2bDDWEuJe xBHKshpWk+gtBOn/bOi9e/I4I9fvl07Px0YL5nygajiyNGfUdUUY12kiMWaEugO54eKH 8Wr4EXTD+SwBZnBbqTV2XksWiPKwRN4vx3f4YVBEIGbCqKQZj0SH5WDAiu9k1UytmYFI ac7UOl4FiS7gd5SOJUNlqAhrMbd4hu9iFsZvJaSEKMAkkuBKm0EA/WhrLoaGNlQwgu8T IggEAhvyDwOJRY/eXFP0SYbqik8UFW2M82IEz2xZQ4Dc1tOA6vNVQY0UoBAvnwn1fZ4N VYjw== X-Gm-Message-State: APjAAAVr31SF7C7lZShAg0uJpI/tL5ZMae2KmAdTnBgyNZylUtwIkJQ/ 1wWI5sy2r2kDl+/b5Lg3lUslnQ== X-Received: by 2002:a17:902:a403:: with SMTP id p3mr20634633plq.275.1574562350095; Sat, 23 Nov 2019 18:25:50 -0800 (PST) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id r16sm3262712pgl.77.2019.11.23.18.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2019 18:25:49 -0800 (PST) Date: Sat, 23 Nov 2019 18:25:45 -0800 From: Jakub Kicinski To: Navid Emamdoost Cc: Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu Subject: Re: [PATCH] sctp: Fix memory leak in sctp_sf_do_5_2_4_dupcook Message-ID: <20191123182545.2c73268a@cakuba.netronome.com> In-Reply-To: <20191122221759.32271-1-navid.emamdoost@gmail.com> References: <20191122221759.32271-1-navid.emamdoost@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Nov 2019 16:17:56 -0600, Navid Emamdoost wrote: > In the implementation of sctp_sf_do_5_2_4_dupcook() the allocated > new_asoc is leaked if security_sctp_assoc_request() fails. Release it > via sctp_association_free(). > > Fixes: 2277c7cd75e3 ("sctp: Add LSM hooks") > Signed-off-by: Navid Emamdoost Applied, queued for stable, thanks!