Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1824664ybc; Sun, 24 Nov 2019 07:01:14 -0800 (PST) X-Google-Smtp-Source: APXvYqyYj0+NWr9mIR+S5ZfEPOpTElgrLpKkK+BDeeH8r+0TzvexcjGjawMjNnO7YbQW8p0sikNK X-Received: by 2002:a05:6402:b2d:: with SMTP id bo13mr12643665edb.125.1574607674884; Sun, 24 Nov 2019 07:01:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574607674; cv=none; d=google.com; s=arc-20160816; b=EmlJNwp03hyRIwdM/+UGqOWj1qPpuomj4/wkkBhRk5ghO9QDb+wDSyrEHSXDHEQvIU B8MaspNEhL+ANVrUyhTMBtD1eUBJZJN39I93wG9Mp4C3ASMmjbIFIdruccuwUejKpjma igJmA+hd0xBxtUKIu4VLlWhbfOt0wg2cbTDpk4wZ8nLKY1MlfWD/EYIepqMX54JnMHbO iY1pGvdCRAHeZY+S2h06/ZrvJmFjTFGA8V5O7lA96vWTreysrZTBy+Pq5JU+oPQ8erU9 maeGjScIgAkLXhkSBZnFztoWs50nBakgOUVQH0anQ/q3Lq+ocEdGOtHz5Tzr/dKdJ29E Y8OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7TvUqmnLt+b9FVG9Ou4XDPjFFiwkZsTBYqLSWeoPxHE=; b=YcLCzFVqcv67yMN7b/JwzNSKeY+0GC29zqqsJIC4jMP6nFcoNjOR4mvWodhpExhVA7 ypQDclDoLR9zibIABo300FS0Gp3YKm/nSoJON0I8EaiYZSM/dfYp4tXlCkDPZMqwNrAd sSiZAyyv4x3R6vFLxn5UMKVOb0FcrohY3XD83SPWjvHr5nxlKNjXz8uf5ETFJzchCgnt m7nW0D+3rfTEcd4QyX72lB79oLQ6F+TrqXqY1GgEnkThl05HxJU8JNTDQN+of5gJOEKJ 5ljv0lgfruvt5uzhB/2Ej9Jza82q0L+qLutLVfIcCiULNxChy6FkN9pmgM5wXtOJ/Xgp BXDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si2842010edp.177.2019.11.24.07.00.49; Sun, 24 Nov 2019 07:01:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbfKXO6z (ORCPT + 99 others); Sun, 24 Nov 2019 09:58:55 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:38363 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbfKXO6y (ORCPT ); Sun, 24 Nov 2019 09:58:54 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=wenyang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0TiwhtFi_1574607525; Received: from localhost(mailfrom:wenyang@linux.alibaba.com fp:SMTPD_---0TiwhtFi_1574607525) by smtp.aliyun-inc.com(127.0.0.1); Sun, 24 Nov 2019 22:58:52 +0800 From: Wen Yang To: Liam Girdwood , Mark Brown Cc: Wen Yang , linux-kernel@vger.kernel.org Subject: [PATCH] regulator: fix use after free issue Date: Sun, 24 Nov 2019 22:58:35 +0800 Message-Id: <20191124145835.25999-1-wenyang@linux.alibaba.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is caused by dereferencing 'rdev' after put_device() in the _regulator_get()/_regulator_put() functions. This patch just moves the put_device() down a bit to avoid the issue. Signed-off-by: Wen Yang Cc: Liam Girdwood Cc: Mark Brown Cc: linux-kernel@vger.kernel.org --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 679ad3d..09a3550 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1938,8 +1938,8 @@ struct regulator *_regulator_get(struct device *dev, const char *id, regulator = create_regulator(rdev, dev, id); if (regulator == NULL) { regulator = ERR_PTR(-ENOMEM); - put_device(&rdev->dev); module_put(rdev->owner); + put_device(&rdev->dev); return regulator; } @@ -2063,13 +2063,13 @@ static void _regulator_put(struct regulator *regulator) rdev->open_count--; rdev->exclusive = 0; - put_device(&rdev->dev); regulator_unlock(rdev); kfree_const(regulator->supply_name); kfree(regulator); module_put(rdev->owner); + put_device(&rdev->dev); } /** -- 1.8.3.1