Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC V4 2/2] This commit introduced IFC operations for vdpa
To:     Zhu Lingshan <lingshan.zhu@intel.com>, mst@redhat.com,
        alex.williamson@redhat.com
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
        netdev@vger.kernel.org, dan.daly@intel.com,
        cunming.liang@intel.com, tiwei.bie@intel.com, jason.zeng@intel.com,
        zhiyuan.lv@intel.com
References: <1574241431-24792-1-git-send-email-lingshan.zhu@intel.com>
 <1574241431-24792-3-git-send-email-lingshan.zhu@intel.com>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <f4cd7ba4-953e-872a-42bd-aa1303c18458@redhat.com>
Date:   Mon, 25 Nov 2019 16:19:46 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1574241431-24792-3-git-send-email-lingshan.zhu@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/11/20 =E4=B8=8B=E5=8D=885:17, Zhu Lingshan wrote:
> +
> +=09if (!strcmp(kobj->name, "ifcvf-virtio_mdev"))
> +=09=09mdev_virtio_set_class_id(mdev,MDEV_VIRTIO_CLASS_ID_VIRTIO);
> +
> +=09if (!strcmp(kobj->name, "ifcvf-vhost_mdev"))
> +=09=09mdev_virtio_set_class_id(mdev,MDEV_VIRTIO_CLASS_ID_VHOST);
> +
> +=09mdev_set_drvdata(mdev, adapter);
> +=09mdev_set_iommu_device(mdev_dev(mdev), dev);
> +=09adapter->mdev_count--;
> +


To avoid confusion, it's better to call mdev_set_iommu_device() only for=20
the case of vhost. For virtio, it doesn't depends on that to work.

Thanks