Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa1.microchip.iphmx.com: domain of
  Eugen.Hristev@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com;
  envelope-from="Eugen.Hristev@microchip.com";
  x-sender="Eugen.Hristev@microchip.com";
  x-conformance=spf_only; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:ushub1.microchip.com
  a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com
  include:servers.mcsv.net include:mktomail.com
  include:spf.protection.outlook.com ~all"
Received-SPF: None (esa1.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com;
  envelope-from="Eugen.Hristev@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: oo5guDN1lTG39BcF3GpeZgKz+iVVifCj5LMim4k+78AGB8dcF65r9o2ugvrv8fypvj46VoRuwD
 ogVPmzV4Yw6I1EMVwsxp2cEs00ImIwynOvYs9wl2L1r7fTcTYkWstmnNMavResQJlNv9JsrAJD
 I87fJHeRpEVA32dl9LV/26KKW2aGQrlnavyW/mSQFv0ueplCiCrto6ZtQaMFGlCPlLN21rkYjt
 vQ3UAFepM0WLrsFFvn+azNvWrylWdQydFZ4oPzD9aWiTUc8kMXt4yp9GqrB2n9e8WtUkuGilhe
 iRY=
From:   <Eugen.Hristev@microchip.com>
To:     <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <hverkuil@xs4all.nl>
CC:     <Eugen.Hristev@microchip.com>
Subject: [PATCH 5/5] media: atmel: atmel-isc-base: initialize the try_crop for
 the pads in try_fmt
Thread-Topic: [PATCH 5/5] media: atmel: atmel-isc-base: initialize the
 try_crop for the pads in try_fmt
Thread-Index: AQHVo2ru8tcTV/dUgUG1OTeEMRIkuQ==
Date:   Mon, 25 Nov 2019 08:32:54 +0000
Message-ID: <1574670712-31992-6-git-send-email-eugen.hristev@microchip.com>
References: <1574670712-31992-1-git-send-email-eugen.hristev@microchip.com>
In-Reply-To: <1574670712-31992-1-git-send-email-eugen.hristev@microchip.com>
Accept-Language: en-US, ro-RO
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [94.177.32.156]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 37699cef-dd7d-4e66-aaf5-08d77182115d
x-ms-traffictypediagnostic: DM5PR11MB1418:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR11MB1418C3E6DC31AEB0584BA2B9E84A0@DM5PR11MB1418.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0232B30BBC
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(346002)(376002)(396003)(366004)(136003)(189003)(199004)(305945005)(2201001)(66476007)(66556008)(76176011)(64756008)(66446008)(26005)(81156014)(81166006)(4326008)(3846002)(50226002)(5660300002)(25786009)(86362001)(8676002)(6116002)(2501003)(52116002)(66946007)(6436002)(66066001)(256004)(6486002)(446003)(14454004)(2906002)(386003)(71200400001)(102836004)(6512007)(2616005)(11346002)(6506007)(478600001)(71190400001)(36756003)(110136005)(107886003)(99286004)(186003)(7736002)(8936002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR11MB1418;H:DM5PR11MB1242.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: wRCHEu5f2Ql2TdoNuGfCgyS7cxMEYSiAyamgY6h4klHEw8+/sCrzYs15bv3avW0GMB5HJYhwqaBUIo+Uuv+JMB7GW144tbYrfIcMjv3jaZcTs0t+czhr+jI1Qn7POJgcJ5Yz/QKA/c2dnom/tZbzy0KbMaAgn4qTP85elE1DsWb9DtUoQABSSkrVJ07Zh+t/b2VJDP93/gu1W9vbGU88emsWFBKu0YUwuR3eTAAy4nUPcaRITgRC0gpO4Y5hMBkE6PqqBr6VF8oFMyf01iNVd5TzfRyBuBNGw3B4aeaI51VDZ8rUMF/FcEGB60qXRtbhHvOcg/FDWkj3HFDVWW+WVpCQYgN9/btzM/D70+xai50ElHbXwDeDLPJm9gfhPoTERXhlRiL5rxwJx6twfO3cSbS7i+qKKPfSLszdN7D7ZIueZt0+sMDNrSTCvMMdhkaz
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 37699cef-dd7d-4e66-aaf5-08d77182115d
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2019 08:32:54.8912
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CKdC/67AKhQgOz7HFAgQIqfDDylK73EvUi3+YLvL7DIylPO+O4ksV00rBF27qE7zo2UlMyEO0xX1kMO3WTMxRw0pEEK2cFaQJkamvyt4sNU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1418
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Eugen Hristev <eugen.hristev@microchip.com>

When requesting format from sensor, some sensors call the subdev_get_try_cr=
op
which for ISC was not properly initialized, and this causes errors in
determining proper image resolutions.
To accommodate for this, when trying a format (in try_fmt), first attempt t=
o
obtain the framesize for this format from sensor.
In case this fails, use the maximum ISC width/height as try_crop, otherwise
provide the first size height/width from the sensor.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/media/platform/atmel/atmel-isc-base.c | 33 +++++++++++++++++++++++=
++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/=
platform/atmel/atmel-isc-base.c
index 1bb1dd5..511f0c5 100644
--- a/drivers/media/platform/atmel/atmel-isc-base.c
+++ b/drivers/media/platform/atmel/atmel-isc-base.c
@@ -1233,6 +1233,36 @@ static int isc_try_configure_pipeline(struct isc_dev=
ice *isc)
 	return 0;
 }
=20
+static void isc_try_fse(struct isc_device *isc,
+			struct v4l2_subdev_pad_config *pad_cfg)
+{
+	int ret;
+	struct v4l2_subdev_frame_size_enum fse =3D {0};
+	/*
+	 * If we do not know yet which format the subdev is using, we cannot
+	 * do anything.
+	 */
+	if (!isc->try_config.sd_format)
+		return;
+
+	fse.code =3D isc->try_config.sd_format->mbus_code;
+	fse.which =3D V4L2_SUBDEV_FORMAT_TRY;
+
+	ret =3D v4l2_subdev_call(isc->current_subdev->sd, pad, enum_frame_size,
+			       pad_cfg, &fse);
+	/*
+	 * Attempt to obtain format size from subdev. If not available,
+	 * just use the maximum ISC can receive.
+	 */
+	if (ret) {
+		pad_cfg->try_crop.width =3D ISC_MAX_SUPPORT_WIDTH;
+		pad_cfg->try_crop.height =3D ISC_MAX_SUPPORT_HEIGHT;
+	} else {
+		pad_cfg->try_crop.width =3D fse.max_width;
+		pad_cfg->try_crop.height =3D fse.max_height;
+	}
+}
+
 static int isc_try_fmt(struct isc_device *isc, struct v4l2_format *f,
 			u32 *code)
 {
@@ -1336,6 +1366,9 @@ static int isc_try_fmt(struct isc_device *isc, struct=
 v4l2_format *f,
 	if (ret)
 		goto isc_try_fmt_err;
=20
+	/* Obtain frame sizes if possible to have crop requirements ready */
+	isc_try_fse(isc, &pad_cfg);
+
 	v4l2_fill_mbus_format(&format.format, pixfmt, mbus_code);
 	ret =3D v4l2_subdev_call(isc->current_subdev->sd, pad, set_fmt,
 			       &pad_cfg, &format);
--=20
2.7.4