Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191125100259.5147-1-o.rempel@pengutronix.de>
 <CA+h21hrwK-8TWcAowcLC5MOaqE+XYXdogmAE7TYVG5B3dG57cA@mail.gmail.com> <caab9bcc-a4a6-db88-aa23-859ffcf6ff85@pengutronix.de>
In-Reply-To: <caab9bcc-a4a6-db88-aa23-859ffcf6ff85@pengutronix.de>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Mon, 25 Nov 2019 12:39:44 +0200
Message-ID: <CA+h21ho9bJsaq8e-gRhRpM+kXARNJ6tyL10vKVf2+7YOtaJGXw@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] net: dsa: sja1105: print info about probet chip
 only after every thing was done.
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     mkl@pengutronix.de, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, kernel@pengutronix.de,
        netdev <netdev@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, david@protonic.nl
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 25 Nov 2019 at 12:32, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> On 25.11.19 11:22, Vladimir Oltean wrote:
> > On Mon, 25 Nov 2019 at 12:03, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> >>
> >> Currently we will get "Probed switch chip" notification multiple times
> >> if first probe filed by some reason. To avoid this confusing notifications move
> >> dev_info to the end of probe.
> >>
> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> >> ---
> >
> > Also there are some typos which should be corrected:
> > probet -> probed
> > every thing -> everything
> > filed -> failed
> >
> > "failed for some reason" -> "was deferred"
>
> Ok, thx.
>
> should i resend both patches separately or only this one with spell fixes?
>

I don't know if David/Jakub like applying partial series (just 2/2). I
would send a v2 to each patch specifying the tree clearly.
Also I think I would just move the "Probed...." message somewhere at
the beginning of sja1105_setup, where no probe deferral can happen.

>
> Kind regards,
> Oleksij Rempel
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Thanks,
-Vladimir