From: "Sean Hefty" <sean.hefty@intel.com>
To: "'Stephen Hemminger'" <shemminger@osdl.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
       <openib-general@openib.org>
Subject: RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction
Date: Tue, 17 Jan 2006 15:51:23 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Thread-Index: AcYbv4GKi3GOH7PgQ7SAUxpZSCxGzgAAKDgg
In-Reply-To: <20060117153838.3dc2cd2e@dxpl.pdx.osdl.net>
Message-ID: <ORSMSX401eBBsQwY6YH00000044@orsmsx401.amr.corp.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 950
Lines: 27

>> +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask)
>
>static void cm_mask_compare_data(u8 *dst, const u8 *src, u8 *mask)
>
>but I would rename it to cm_mask_copy since it doesn't really do a compare.

I'll change this.  The function is masking the "data to use in the comparison",
but I can see the confusion.

>> +static int cm_compare_data(struct ib_cm_private_data_compare *src_data,
>> +			   struct ib_cm_private_data_compare *dst_data)
>
>static int cm_compare_data(const struct ib_cm_private_data_compare *src,
>		           cosnt struct ib_cm_private_data_compare *dst)
>Your data type names are getting too long ^^^^^^^^^^^^^^^^^^^^^^^^

I'll fix.

Thanks for the comments.

- Sean

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/