Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Nov 2019 20:09:10 +0530
From:   Nishad Kamdar <nishadkamdar@gmail.com>
To:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: Use the correct style for SPDX License
 Identifier
Message-ID: <20191125143900.GA2572@nishad>
References: <20191123130815.GA3288@nishad>
 <20191123183455.6266e9a8@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191123183455.6266e9a8@cakuba.netronome.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 23, 2019 at 06:34:55PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Nov 2019 18:38:19 +0530, Nishad Kamdar wrote:
> > diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
> > index 5a16caab7b2f..40e0be0f4e1c 100644
> > --- a/drivers/net/phy/aquantia.h
> > +++ b/drivers/net/phy/aquantia.h
> > @@ -1,5 +1,5 @@
> > -/* SPDX-License-Identifier: GPL-2.0
> > - * HWMON driver for Aquantia PHY
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*  HWMON driver for Aquantia PHY
> 
> You're adding an extra space here. Is this intentional?

No, It shouldn't be there.

Thanks you for pointing it out.
I'll update and resend the patch.

Thanks for the review.

Regards,
Nishad

> 
> >   *
> >   * Author: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> >   * Author: Andrew Lunn <andrew@lunn.ch>