Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2945628ybc; Mon, 25 Nov 2019 06:41:34 -0800 (PST) X-Google-Smtp-Source: APXvYqwTF7jQ5IRQt/ZPpi8HR4vbV04hd8hjEDXSju62lONKGouzuvc3COzzyK1r2u2lmpJJO/Bz X-Received: by 2002:a17:906:4098:: with SMTP id u24mr36848554ejj.220.1574692894766; Mon, 25 Nov 2019 06:41:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574692894; cv=none; d=google.com; s=arc-20160816; b=VoxxGqLMTPUF6IQi+o2THOSrD4Z9X2tXJnSWd5z34hvLLZ1m2x5NBnNHl0jYcZ1ZDg SshkrueXOkOkieIPt++wMJu50O87kLdnkvKowx2v+CamxQ15eq8p+hp3s93sKsBozma+ pv9OxWeznmGqeTXL8hTkQMCUYpLR5k5vHeuRA5O26PYVxzArDOz9ctHlTqtp0vcbK6NO IROAdLnkS+5tumgsBUi71DkSQtTJvw8FQgnYZ/JQSKblZJa4gtZlglgsByFs6RnpJTZO 7n+ud00gyXczR7IYli6XmmyWzqECyPXXrutV7BHvvsGdIK5jeBUXP26Szx3atTppt+ip qkBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ysuSQwdoiGXVRPkAiaiJnsu2siAicLc8PmRbx8aQeCc=; b=hfTYN62yXxtuRj+nGMSH8oe1+83i+PRtdZt15+RnAUN/V8Fbf5GAi6w7bfQLRVXQwF 44ifmPeTyHrQF1BH6pVwcRQ0M53NYbNdjdZEQsU8q1xSy/oq4bFEgFSdzJN/YjTfFefI ognplF5x+NTq44JkTPLP9ue5eh1k7Cy1rVcFDv++NKWy2iRq5AAi5x2IlOSNMmCDY4tr H2TQati+XwFCZYIJmsn5vulTwTQSmAcQd+z+XkgCTwRpVIKbWC69Zd4KOIXQB2wOAWdW OZvl5R76CE4brZpotzJTjfQrUxD3WWFdVJZelgB9F3LLSLrgrRBEbjtCFD5m8/OxUYCN OLlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XTzuu8Wg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cc20si5774834edb.201.2019.11.25.06.41.09; Mon, 25 Nov 2019 06:41:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XTzuu8Wg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbfKYOg4 (ORCPT + 99 others); Mon, 25 Nov 2019 09:36:56 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34564 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728035AbfKYOgz (ORCPT ); Mon, 25 Nov 2019 09:36:55 -0500 Received: by mail-pl1-f196.google.com with SMTP id h13so6604860plr.1 for ; Mon, 25 Nov 2019 06:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ysuSQwdoiGXVRPkAiaiJnsu2siAicLc8PmRbx8aQeCc=; b=XTzuu8Wgu30lZCM2ZeocPdBnl/r97cfM41I9es+Qqx5Lft/DxiSHuuori/v16kK+US DhVT2ilvxqvVbAKtT6RH5r4dcGb5D2nl9WPZ3Gsblik1WxPB9h6KvlbTmoEXVC0h1n0b D+XkP4sfNian+dJMkF+AJ8jbiu68v1zNiwwDZa9WjmI3Cf/384h8QOZIbdb87Zj2JQJQ 7ICiYZ9cXVgb6rDY47PNDsEi3F3AzmeQH0rXF3tcjfX2cgLNYgQzi5UPZXpvV/X6YXOu UAiHb0AFdSYFuqyU3bqP1n0QZYQqnwXmWYSaqEb8JdfMMRK2HtDKKuN70DJgqG3ysVMr 8xwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ysuSQwdoiGXVRPkAiaiJnsu2siAicLc8PmRbx8aQeCc=; b=ptaSW/C33/laRheCXf+retF8l2ZpOq6uLM5HkmCaENrtTMCMTEo8SDpwI8SKSE4lUl Eq4fDVf7Nru/luWSnX8dxeVEm9+xpDxOL8TTXxdYCyANHYzEIk4HP66JGM/aP9tVIJZ6 We6nAeH6+smI6DqxdzNlxcuxNhefGzB2OX/EFT3wwlyvVJi3MrWIFY/0ZEoYliTvL6YG xcWY3n3ox3npCNojFPh+5tzc6gJEuZFadUtKMf2fSrNK9Z0PsqAVPMs4GrnNarpiArMN xqg42OZ6f2wCeTQVqnMV1hCI11gSeEKMoop1vv0W0UrHcpiFO5eUrPi5uSrFMHoUtVKe 9Edg== X-Gm-Message-State: APjAAAWgmKlIqtWVsQX6dIgv6KBrHwDVj2XxGebeqBemGerpfSPzPRyt glDTO056X2bqPLWu6kr1hEM= X-Received: by 2002:a17:90a:1913:: with SMTP id 19mr40651035pjg.116.1574692614883; Mon, 25 Nov 2019 06:36:54 -0800 (PST) Received: from mail.google.com ([139.180.133.10]) by smtp.gmail.com with ESMTPSA id v19sm8821547pjr.14.2019.11.25.06.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 06:36:54 -0800 (PST) Date: Mon, 25 Nov 2019 22:36:46 +0800 From: Changbin Du To: Jiri Olsa Cc: Changbin Du , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] perf: add support for logging debug messages to file Message-ID: <20191125143644.5tkkazvlke5wcbcw@mail.google.com> References: <20191018002757.4112-1-changbin.du@gmail.com> <20191123040910.dfi65lbev7ydtbdo@mail.google.com> <20191125092758.GA4675@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125092758.GA4675@krava> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 25, 2019 at 10:27:58AM +0100, Jiri Olsa wrote: > On Sat, Nov 23, 2019 at 04:09:10AM +0000, Changbin Du wrote: > > Hi Jiri, In case you missed this one in your mailbox. :) > > sry I mised this and can't apply this anymore.. could you please > rebase it to current Arnaldo's perf/core? > no problem, please check it later. > thanks, > jirka > > > > > On Fri, Oct 18, 2019 at 08:27:55AM +0800, Changbin Du wrote: > > > When in TUI mode, it is impossible to show all the debug messages to > > > console. This make it hard to debug perf issues using debug messages. > > > This patch adds support for logging debug messages to file to resolve > > > this problem. > > > > > > v5: > > > o doc default log path. > > > v4: > > > o fix another segfault. > > > v3: > > > o fix a segfault issue. > > > v2: > > > o specific all debug options one time. > > > > > > Changbin Du (2): > > > perf: support multiple debug options separated by ',' > > > perf: add support for logging debug messages to file > > > > > > tools/perf/Documentation/perf.txt | 16 ++-- > > > tools/perf/util/debug.c | 124 ++++++++++++++++++++---------- > > > 2 files changed, 92 insertions(+), 48 deletions(-) > > > > > > -- > > > 2.20.1 > > > > > > > -- > > Cheers, > > Changbin Du > > > -- Cheers, Changbin Du