Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Nov 2019 09:39:32 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc:     Kusanagi Kouichi <slash@ac.auone-net.jp>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] arm: exynos_config: Restore debugfs support
Message-ID: <20191125093932.4a111dc8@gandalf.local.home>
In-Reply-To: <7f6a5924-58f9-aafb-18c5-c749ad355a02@samsung.com>
References: <CGME20191125125531eucas1p17f4044301903eeafe56865ed63738798@eucas1p1.samsung.com>
        <20191125125515.30795-1-m.szyprowski@samsung.com>
        <7f6a5924-58f9-aafb-18c5-c749ad355a02@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 25 Nov 2019 15:30:39 +0100
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:

> It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") disabled DEBUG_FS also in some other ARM defconfigs.
> 
> For some of them it may be a correct change but a preferred way to
> introduce such changes would be to:
> 
> - add explicit CONFIG_DEBUG_FS=y instances to all affected defconfigs
>   while removing DEBUG_FS selection from TRACING config item
> 

I strongly disagree. It was wrong to assume DEBUG_FS is attached to
TRACING. If someone wanted DEBUG_FS in their def config, they should
have added it specifically. The addition of DEBUG_FS to defconfigs no
way belongs to the patch that removed DEBUG_FS from TRACING.

-- Steve


> - let platform maintainers disable DEBUG_FS manually in corresponding
>   defconfigs later if desirable