Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3212174ybc; Mon, 25 Nov 2019 10:43:30 -0800 (PST) X-Google-Smtp-Source: APXvYqzh5TtUdWjOWpnxzUnMQXyXVrTSASM2+HGD+5WQSj9fgZDVs6YJaQ5N4VZEdXLW4kze+lfI X-Received: by 2002:a17:906:c41:: with SMTP id t1mr38145040ejf.282.1574707410650; Mon, 25 Nov 2019 10:43:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574707410; cv=none; d=google.com; s=arc-20160816; b=NJclzH8dvjsXSIZpl3cP/l48hHxQNrupwuvBBt2VXuRCoELzWpRxacHVc64HpKuaKV L8Wr0z+6CO3JcxxXVxh5tmPtk4WsDojJy4Ht1M15KKE4ukGmzZy9WRzZrrhf7pL/3KH1 cJ5K34lhtMlbNjU9slG9obNWOrzzBdfteSEr0bS6lbqrqHjtwIUPaUVReg3Bd0tiOYvI kbc85TTkydGaRBdzXURoTNHLjSZTA8Ex6mRpNJsiztA6fG96bbL+kG8SFaSF6ZDxOsjr C/xIxvKe0RcY+aJomu8XP/CfwYBU6/0G5glgPv2CXB3zeIkON0GX+1Tyc5GQ9+lsnBd9 NchQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=WacjdKZ2e3FNiFE7cuED4QoV4ne9xGzpZCLIT+BEfbw=; b=xNf4TMi5YOErQdI7mxqQKd5CVBmkQx3/2Ft9PXI860eN6U/bBGSRNrlcgF+/DSqD9w ZWFsVMce1nnLXb+/N+ZkEVa2tIvAzUrIscFuKEb6rfLDJbffDkf4RyhYdPaUoAofkrXs 2Ocg/tGgaigaCRmKsFVVUtxgs6ZbjjTf7jByrcsml3/TBpISub6DOjFQXVB4ZzbsdPbL 00m0aGH+5vvt/s9jJuZEPgZglw0iHerhmTLrNNwJtZ5Tu1S0nipFnZTxPTSyDWvsVzVO XGHn51Z77qrCgFi347LiAI7KYojzvhHNpLS6Pn9wST1dkQXY5O2ZoXxSo17XwcSjM0fQ Q6yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14si5278762ejt.381.2019.11.25.10.43.06; Mon, 25 Nov 2019 10:43:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbfKYOqn (ORCPT + 99 others); Mon, 25 Nov 2019 09:46:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:42252 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728072AbfKYOqm (ORCPT ); Mon, 25 Nov 2019 09:46:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C18E6B44A; Mon, 25 Nov 2019 14:46:40 +0000 (UTC) Date: Mon, 25 Nov 2019 15:46:40 +0100 Message-ID: From: Takashi Iwai To: Jian-Hong Pan Cc: Takashi Iwai , Kailang Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux@endlessm.com Subject: Re: [PATCH] ALSA: hda/realtek - Enable internal speaker of ASUS UX431FLC In-Reply-To: <20191125093405.5702-1-jian-hong@endlessm.com> References: <20191125093405.5702-1-jian-hong@endlessm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Nov 2019 10:34:06 +0100, Jian-Hong Pan wrote: > > Laptops like ASUS UX431FLC and UX431FL can share the same audio quirks. > But UX431FLC needs one more step to enable the internal speaker: Pull > the GPIO from CODEC to initialize the AMP. > > Fixes: 60083f9e94b2 ("ALSA: hda/realtek - Enable internal speaker & headset mic of ASUS UX431FL") > Signed-off-by: Jian-Hong Pan Thanks, applied now. Takashi