Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3221108ybc; Mon, 25 Nov 2019 10:53:10 -0800 (PST) X-Google-Smtp-Source: APXvYqxpZzT1m8mZtp/4WjonlEF8YzpMKfJk/Kq8oWhctZatH00yzzSVAFN5caQAASAAPWt9KJ/9 X-Received: by 2002:a17:906:2241:: with SMTP id 1mr38486376ejr.16.1574707989897; Mon, 25 Nov 2019 10:53:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574707989; cv=none; d=google.com; s=arc-20160816; b=h1UZ9NwAyn2oQE17XhXNWHaHgQjPh1kBy+4DO6fP7rsJ4N7hKt2u0Re3itEWmQ+po/ jR4CbsYm1ow7xP7nUULQtjbK8iUTNoOCH4IrxsHsj3DiAR0MMVWYoA8D860vxvxSLZ9K 8VbtJPYkVujCHxy6wAfKBKillBq+tdiwL3LOAe3/eu5UBgbUkmiaJtslroKF0/PM45kW 4toYAOlzmDXqLcYEyU9fJs1U4QKZxk86tbmC948lYRA+lvM11zciIFey8RG9cb/5W3oy wxwV5adnoyWNlfoW/SUjwQ7sjTvFb1aZIYsSLeox6VJdlq/qhYmq9ZdcDA/Ewocal6Et pkJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uxPYNIRvXaDDaZYdugd2AISuQeyYM+VNm+o9iO+FosU=; b=v37Y3r9KBZDVvzWO/Py1QyiNVsz6OeghlgpNR7KvoXNEqNu5aCBAy3MyYIOHavBFAl HeRVLa28i9ziZqUmDZjIhGBfcL+3OcMR7W0W5Iis7OuhZvZwuS9Ht/Wnsi2MKplXEhpp nNukW2I+aAaDgOTH7ea4YiXa5A20jA30Y5xq+hEaawKsUCF7/8TnZXTI5y9Rb7/5M5hS mzkwxVVOIu7BUY9HDKTpZrHWQQrxhX6rLEPRSmg7bNHpKaZus5KopqmboFEP5Y4d3t0D JLdm4/y3Z4JqXdo28Sg12JmUXPOtjxzAMuZYScnPjBRAVzyP0bMnTkye5VuHM0QW61ew DcNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=U+XkpZq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5si5401443eds.263.2019.11.25.10.52.45; Mon, 25 Nov 2019 10:53:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=U+XkpZq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729187AbfKYRkn (ORCPT + 99 others); Mon, 25 Nov 2019 12:40:43 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:45192 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfKYRkm (ORCPT ); Mon, 25 Nov 2019 12:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uxPYNIRvXaDDaZYdugd2AISuQeyYM+VNm+o9iO+FosU=; b=U+XkpZq0mAiGvkr+/u5C2Ze7b AR1n4xm4BNQUrTkqlPPE0rcpm1pR6sa60/rRHZzmhg4mIwOXqWLFypEd2raGJ91PKejoKMpLmUgJj L9frT+KC/V3hufQz9PCcHGyvyDUOK4bqYHFPatuUV0XsB4gzfQn7q9z1UZ+s0DP+BNRKabABJUTj9 hVBl/rOvW5TxIC/22b2Hx4bDNuk2GXNRKmLll6b5F4fc6n7/azGk0RA4RVk+ccH6t7WZyi3Tz4PCL uHvv4EdPRi+ISff4Zn65dv4ONfunfxDIrnYedwp3OE+Ts28LcTy8cX2PnLFTR2Vi2TCNOEwQ+j57L DQCqLcRAw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZILl-0001gv-Sp; Mon, 25 Nov 2019 17:40:37 +0000 Date: Mon, 25 Nov 2019 09:40:37 -0800 From: Christoph Hellwig To: Kees Cook Cc: Christoph Hellwig , Jens Axboe , syzbot+21cfe1f803e0e158acf1@syzkaller.appspotmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Replace bio_check_ro()'s WARN_ON() Message-ID: <20191125174037.GA768@infradead.org> References: <20180824211535.GA22251@beast> <201911221052.0FDE1A1@keescook> <20191122190707.GA2136@infradead.org> <94976fb5-12d3-557d-7f31-347d6116b18c@kernel.dk> <20191122191434.GA10150@infradead.org> <201911221131.A34DFAA49@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201911221131.A34DFAA49@keescook> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So I looked at this a bit, and doing the right thing (TM) will be a little invase and thus not for 5.5. But the 5.5. queue already has a patch from Mikulas Patocka: 8b2ded1c94c ("block: don't warn when doing fsync on read-only devices") which should deal with this issue, and in fact I can't trigger the WARN_ON with Jens' latest tree.