Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3226354ybc; Mon, 25 Nov 2019 10:59:07 -0800 (PST) X-Google-Smtp-Source: APXvYqws4agecuGt1RiRHeeHZjd9uO6/UIhfDZUrLneywObKnbS/vQWrJu+xLGV0s4bENpSV7fxh X-Received: by 2002:a17:906:9716:: with SMTP id k22mr13101716ejx.233.1574708346898; Mon, 25 Nov 2019 10:59:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574708346; cv=none; d=google.com; s=arc-20160816; b=vCPlmZuHmqg4WjZHLMok7qLL6AcSuMqkaNcMXhkYqBrj7YW8qQeT/prCo+CL+X2dWH eplWLyh7nW4oYpaJAlwM2xVfIzFFs34Oynj9mB1QMs9z5uUit+HXYL7WjhxVcflfg6lg lOPa3jl11XAXt2OBwFTOgCJC8TW1kF5CxIAVmY+B/20bRusVGZvjDEsu2w7MQA0/EINz q4s0RTkZHVQVZVXYb1e25Sr2H0kjpIxOAlCPuVm9lZRUcTvjYCEWQwPB8SgQC+m6S61c bjAuw+71mGKuxq7btbbzb08hfr60MyoofkKVjri019H+a3YSa+978eOcd83Eoi3Hc1Mm h4fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hSo6wQ4AGpqxrpHIbvv244y5Vlq1E4lbifI4SCPcqRY=; b=gf4tOyC53+FM/NW6pG63vJEehbrhCDFE46raENI5uHHdHPUFeVjv5Ddi0kZ5kfef3H rv/k5TT/3h00isZvdzNaljo77km7vqAbCNBQy0Lv0etQGaQJJ/fRQAKZdPt9X9mprk26 c5ZVmrboHzPlHoLCLzRREQs7HucJFVGcqvDfabf8rQozaryD8D5CCBEabTQEjjBHAkFx LchN22XMjP/RZiu4cMaLaGQ/c2dvoRv2JX3BkgdOshfBzrwUD4oax7bD8xJZ6ugRRuKK YAVDwlSJjEn1CcBeo8GPePhz1sSYLtfBRhD6ad5kycYj4s622HXG7/jbdwHQVAo94s/f fXrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2si4997706ejr.260.2019.11.25.10.58.43; Mon, 25 Nov 2019 10:59:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbfKYS5A (ORCPT + 99 others); Mon, 25 Nov 2019 13:57:00 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52918 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbfKYS47 (ORCPT ); Mon, 25 Nov 2019 13:56:59 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9AD6615009FB5; Mon, 25 Nov 2019 10:56:58 -0800 (PST) Date: Mon, 25 Nov 2019 10:56:58 -0800 (PST) Message-Id: <20191125.105658.1887728338689510269.davem@davemloft.net> To: o.rempel@pengutronix.de Cc: mkl@pengutronix.de, olteanv@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, david@protonic.nl Subject: Re: [PATCH v2] net: dsa: sja1105: fix sja1105_parse_rgmii_delays() From: David Miller In-Reply-To: <20191125114351.26694-1-o.rempel@pengutronix.de> References: <20191125114351.26694-1-o.rempel@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Nov 2019 10:56:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleksij Rempel Date: Mon, 25 Nov 2019 12:43:51 +0100 > This function was using configuration of port 0 in devicetree for all ports. > In case CPU port was not 0, the delay settings was ignored. This resulted not > working communication between CPU and the switch. > > Fixes: f5b8631c293b ("net: dsa: sja1105: Error out if RGMII delays are requested in DT") > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean Applied and queued up for -stable, thanks.