Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-12-arnd@arndb.de>
 <1634aafd2a99cedceb63efe57e4c7e0a7317917b.camel@codethink.co.uk>
In-Reply-To: <1634aafd2a99cedceb63efe57e4c7e0a7317917b.camel@codethink.co.uk>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 25 Nov 2019 21:26:23 +0100
Message-ID: <CAK8P3a2EfQnLjVfg6U0vCUp1S49CoWCMj-i8ojzbWEUAJAWV+Q@mail.gmail.com>
Subject: Re: [Y2038] [PATCH 21/23] y2038: itimer: change implementation to timespec64
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc:     y2038 Mailman List <y2038@lists.linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kees Cook <keescook@chromium.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 21, 2019 at 5:52 PM Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
>
> On Fri, 2019-11-08 at 22:12 +0100, Arnd Bergmann wrote:
> [...]
> > @@ -292,8 +296,8 @@ static unsigned int alarm_setitimer(unsigned int seconds)
> >        * We can't return 0 if we have an alarm pending ...  And we'd
> >        * better return too much than too little anyway
> >        */
> > -     if ((!it_old.it_value.tv_sec && it_old.it_value.tv_usec) ||
> > -           it_old.it_value.tv_usec >= 500000)
> > +     if ((!it_old.it_value.tv_sec && it_old.it_value.tv_nsec) ||
> > +           it_old.it_value.tv_nsec >= 500000)
> [...]
>
> This is now off by a factor of 1000.  It might be helpful to use
> NSEC_PER_SEC / 2 here so no-one has to count the 0 digits.

Fixed now, thanks a lot for pointing it out!

        Arnd