Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3392794ybc; Mon, 25 Nov 2019 13:48:57 -0800 (PST) X-Google-Smtp-Source: APXvYqxyYmo5L6zQn8t4perQuqFO9ZwrC3k2XOS9mKoCIRlgn2RbDrczInHU5K6MuUq66ZsGIJr9 X-Received: by 2002:a17:906:b253:: with SMTP id ce19mr13452755ejb.61.1574718537597; Mon, 25 Nov 2019 13:48:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574718537; cv=none; d=google.com; s=arc-20160816; b=dD2N2H4HXZChV+xEy6+NGSx8VnvumS/ieo9+1Cp0f+eytUAoDcljNV9lmLo9zBGC4n bJUbTdOwhb9/Hs5kw7w6Gm7q42H7USXWftsZ6789a0xzYw11s6402qTpqRVKqqxkbFbn 0GIukhlQBepV2XgKvQc9QCbUW71V8IteNfIwLbzZGBJwDfeV5YHJXmgxYCFEh40TivT3 GeQEnKd2khpRB72K2L0q8oz8dE7l/ZyZKtvqgwqTXMt6YCQaGT8xRDusAGkxHCvY3Nq/ zqelbxFx6PXXw6Gy34Vp/eH/UCRCOEucgrMqRTDQ7tiBCpDpmH/wyDvxbFQXgyWSI4TM DYTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:reply-to:from:date; bh=IdXtwZbfUu3JZYtHc3YTNTIvFw9IItHTH0WOH0M3IQs=; b=E2Kuv63UzZ5F5KWv6sD6MRWsoSyeafVRD3KQ+KcFlcivyVyhbRYtdB9TuhwutN/o1V 5/whfqrA07X0YaoIaxPEXJlaG3kWV6g7PYVlD3xBqZO8UyscsmlGQb720e8UaZpLwGMp blmr9QEqQyNTzqel41lWw8PYlVrioqgkKcBi4tuQnDALtPhE7RMj4EFuy2TkrEEBlCOe XJ9U8qqjEoKBR3lRwJMPzpr+E4wTDoCFLufFubelJyXf0WUJ5CQAy3Nyj6y/DJM4GuQY rORJF4VtQijLP0UELgfaDpkcygBvG3LCyPfJuiqj56ZL7cF30q8UxW7vmWVy/UpMyB4x cgVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v27si6457192ejk.63.2019.11.25.13.48.33; Mon, 25 Nov 2019 13:48:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbfKYVqf (ORCPT + 99 others); Mon, 25 Nov 2019 16:46:35 -0500 Received: from l2mail1.panix.com ([166.84.1.75]:50933 "EHLO l2mail1.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfKYVqf (ORCPT ); Mon, 25 Nov 2019 16:46:35 -0500 X-Greylist: delayed 945 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Nov 2019 16:46:33 EST Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by l2mail1.panix.com (Postfix) with ESMTPS id 47MKvr2g9lzDkf for ; Mon, 25 Nov 2019 16:30:48 -0500 (EST) Received: from hp-x360n (50-76-61-131-ip-static.hfc.comcastbusiness.net [50.76.61.131]) by mailbackend.panix.com (Postfix) with ESMTPSA id 47MKvq2mkdz1tRQ; Mon, 25 Nov 2019 16:30:47 -0500 (EST) Date: Mon, 25 Nov 2019 13:30:45 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: torvalds@linux-foundation.org cc: linux-kernel@vger.kernel.org Subject: Commit 0be0ee71 ("fs: properly and reliably lock f_pos in fdget_pos()") breaking userspace Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FYI. Don't know if the fault lies with these subsystems or not, but I know it's been a goal to keep things working. In both cases, reverting this commit fixes both these issues. If you need additional information from me, please let me know. First issue manifests itself as a timeout in KDE's upower daemon: ---- Nov 25 13:18:51 hp-x360n systemd[1]: upower.service: Start operation timed out. Terminating. Nov 25 13:18:51 hp-x360n systemd[1]: upower.service: Main process exited, code=killed, status=15/TERM Nov 25 13:18:51 hp-x360n systemd[1]: upower.service: Failed with result 'timeout'. Nov 25 13:18:51 hp-x360n systemd[1]: Failed to start Daemon for power management. Nov 25 13:18:51 hp-x360n systemd[1]: upower.service: Service RestartSec=100ms expired, scheduling restart. Nov 25 13:18:51 hp-x360n systemd[1]: upower.service: Scheduled restart job, restart counter is at 9. Nov 25 13:18:51 hp-x360n systemd[1]: Stopped Daemon for power management. Nov 25 13:18:51 hp-x360n systemd[1]: Starting Daemon for power management... ---- Second issue: ---- Nov 25 13:19:22 hp-x360n kernel: [ 861.213047] INFO: task vmware-vmblock-:1179 blocked for more than 737 seconds. Nov 25 13:19:22 hp-x360n kernel: [ 861.213053] Tainted: G U 5.4.0-Kenny+ #8 Nov 25 13:19:22 hp-x360n kernel: [ 861.213054] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. Nov 25 13:19:22 hp-x360n kernel: [ 861.213056] vmware-vmblock- D 0 1179 1 0x00000000 Nov 25 13:19:22 hp-x360n kernel: [ 861.213060] Call Trace: Nov 25 13:19:22 hp-x360n kernel: [ 861.213068] ? __schedule+0x2b8/0x580 Nov 25 13:19:22 hp-x360n kernel: [ 861.213071] schedule+0x36/0xc0 Nov 25 13:19:22 hp-x360n kernel: [ 861.213074] schedule_preempt_disabled+0x11/0x20 Nov 25 13:19:22 hp-x360n kernel: [ 861.213077] __mutex_lock.isra.11+0x2f0/0x500 Nov 25 13:19:22 hp-x360n kernel: [ 861.213082] __fdget_pos+0x42/0x50 Nov 25 13:19:22 hp-x360n kernel: [ 861.213085] do_writev+0x2f/0x110 Nov 25 13:19:22 hp-x360n kernel: [ 861.213088] do_syscall_64+0x46/0x170 Nov 25 13:19:22 hp-x360n kernel: [ 861.213091] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Nov 25 13:19:22 hp-x360n kernel: [ 861.213094] RIP: 0033:0x7f4c6da1d527 Nov 25 13:19:22 hp-x360n kernel: [ 861.213098] Code: Bad RIP value. Nov 25 13:19:22 hp-x360n kernel: [ 861.213100] RSP: 002b:00007f4c6d6aebc0 EFLAGS: 00000297 ORIG_RAX: 0000000000000014 Nov 25 13:19:22 hp-x360n kernel: [ 861.213102] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f4c6da1d527 Nov 25 13:19:22 hp-x360n kernel: [ 861.213103] RDX: 0000000000000002 RSI: 00007f4c6d6aec50 RDI: 0000000000000003 Nov 25 13:19:22 hp-x360n kernel: [ 861.213104] RBP: 00007f4c6d6aec50 R08: 0000000000000001 R09: 00007f4c6ce8c700 Nov 25 13:19:22 hp-x360n kernel: [ 861.213106] R10: 00007f4c68000080 R11: 0000000000000297 R12: 0000000000000002 Nov 25 13:19:22 hp-x360n kernel: [ 861.213107] R13: 0000000000020000 R14: 0000000000000000 R15: 0000000000000000 ---- -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley