Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20191125125531eucas1p17f4044301903eeafe56865ed63738798@eucas1p1.samsung.com>
 <20191125125515.30795-1-m.szyprowski@samsung.com> <7f6a5924-58f9-aafb-18c5-c749ad355a02@samsung.com>
 <20191125093932.4a111dc8@gandalf.local.home> <5fdca7d0-c130-457a-2ce2-74f645b60f8d@samsung.com>
In-Reply-To: <5fdca7d0-c130-457a-2ce2-74f645b60f8d@samsung.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Tue, 26 Nov 2019 09:21:27 +0800
Message-ID: <CAJKOXPept5Po3UDfLWCTYEupiip-Y6ZXtdaOGTQd8K-6m11DbA@mail.gmail.com>
Subject: Re: [PATCH] arm: exynos_config: Restore debugfs support
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     Kusanagi Kouichi <slash@ac.auone-net.jp>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 25 Nov 2019 at 23:31, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> On 11/25/19 3:39 PM, Steven Rostedt wrote:
> > On Mon, 25 Nov 2019 15:30:39 +0100
> > Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
> >
> >> It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_=
FS
> >> dependency") disabled DEBUG_FS also in some other ARM defconfigs.
> >>
> >> For some of them it may be a correct change but a preferred way to
> >> introduce such changes would be to:
> >>
> >> - add explicit CONFIG_DEBUG_FS=3Dy instances to all affected defconfig=
s
> >>   while removing DEBUG_FS selection from TRACING config item
> >>
> >
> > I strongly disagree. It was wrong to assume DEBUG_FS is attached to
> > TRACING. If someone wanted DEBUG_FS in their def config, they should
> > have added it specifically. The addition of DEBUG_FS to defconfigs no
>
> There is a theory and a practice.
>
> In theory you are are correct. ;-)
>
> In practice people don't manually edit configuration files nowadays.
>
> They do 'make menuconfig' and enable what they need and disable what
> they do not need.  Then they do 'make savedefconfig' and copy resulting
> "stripped" defconfig file as their new platform defconfig. As a result
> defconfigs rely on many default settings (also they explicitly disable
> only items that are enabled by default but you don't want them).

I agree with Bart=C5=82omiej. Your interpretation Steven essentially
prohibits any use of savedefconfig to trim automatically the config
from unneeded options. Therefore many defconfigs which do not have
DEBUG_FS or other options directly, but they want it.

Some time ago I had patches removing specific non-existing options
from defconfigs. For each option I provided a rationale that it is
gone/etc so let's remove it from defconfig. Most of maintainers picked
them up but few (2-3?) instead run savedefconfig to clean up
everything automatically.

Best regards,
Krzysztof