Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: R4kmXRcaj591iUOU4yCeGI5QuQ6c4y1TjOikg4B5Uz7oNoP6WujatY5NP8OwaMSzFhbt46xrm0
 a8oIbeKmhThXKZZVWLoK4BRPlTjO8H8KnqPaqUPJY63sy/Y7SjL1VSxgDmuLIwNYEbEWTTCf5y
 B9I/Fr3GKn4cymjMHuSji+kSnoqZ6UtjL5ByFlhc7Z1ZbqERniv3nEuwMjcR4YramBpaIxZL+p
 vqo69iUb5ZoGwj/tfQsN1zHFVor/wQG9lvMc0mEqC/D99VlDgWWby/uh6+Vc47BU8Wb/r+fM4k
 TG0=
IronPort-SDR: WvTKzuOd12GujAB85hs7+PVG2OVR6fjGYCgKFbamx25KzPWW7DJwK+/1mi8s1KaCJzUBEEH7Uq
 03CtdDMCsxklQyDrnsV2scNBplcyxJxbpmuBInMwp7qS415EiAL65ud8wmtsXoyjkugG9hO1QN
 3Aqo4AZXb7rNmQxzosPGYzkslO3UHgxvwgoWXBLFuFgpkMxv8c1WYMbZzAizbzWCQ5MfuYwZnO
 FJYz2/pZ2UBx/v/iXho3aPNIS06uiblY6ysuUgnpOWqvRNn3PwT6jVo49dAEWh6PoIKi0vrTHL
 iSpoZAim+hAS4S8vV6hkklBh
IronPort-SDR: sxuwJ1p2iDmM5pXbjUF/DAx9OEkWJeCr7QyVHAX6TIUSkZSZpWZ+Pesxagx83phxenScE1wNk/
 mRIeItZUHcbUkhQ/J3eL88a62UAuwtlIRaLBNIbjdcKr+aPk8xUtoO2mU9EYUovW3sut6ngT3Z
 tx8edEQc8mOaatEK6eLtY/HoQ5aip5dEqqcx8YMJVoG0OMZgUEcZnkp/J3hPxAXLJwFfzaZ9L+
 cvJyT4QZ3h8nq/oE7t/wbdEnN/lcX4msHc+k+lkhJ1Ut0qLxdXePjX7PmLgmTiLQE1+HdgysYc
 XSM=
WDCIronportException: Internal
From:   Damien Le Moal <damien.lemoal@wdc.com>
To:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
        Chao Yu <yuchao0@huawei.com>
Cc:     linux-fsdevel@vger.kernel.org,
        Javier Gonzalez <javier@javigon.com>,
        Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH] f2fs: Fix direct IO handling
Date:   Tue, 26 Nov 2019 16:57:19 +0900
Message-Id: <20191126075719.1046485-1-damien.lemoal@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

f2fs_preallocate_blocks() identifies direct IOs using the IOCB_DIRECT
flag for a kiocb structure. However, the file system direct IO handler
function f2fs_direct_IO() may have decided that a direct IO has to be
exececuted as a buffered IO using the function f2fs_force_buffered_io().
This is the case for instance for volumes including zoned block device
and for unaligned write IOs with LFS mode enabled.

These 2 different methods of identifying direct IOs can result in
inconsistencies generating stale data access for direct reads after a
direct IO write that is treated as a buffered write. Fix this
inconsistency by combining the IOCB_DIRECT flag test with the result
of f2fs_force_buffered_io().

Reported-by: Javier Gonzalez <javier@javigon.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 fs/f2fs/data.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5755e897a5f0..8ac2d3b70022 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1073,6 +1073,8 @@ int f2fs_preallocate_blocks(struct kiocb *iocb, struct iov_iter *from)
 	int flag;
 	int err = 0;
 	bool direct_io = iocb->ki_flags & IOCB_DIRECT;
+	bool do_direct_io = direct_io &&
+		!f2fs_force_buffered_io(inode, iocb, from);
 
 	/* convert inline data for Direct I/O*/
 	if (direct_io) {
@@ -1081,7 +1083,7 @@ int f2fs_preallocate_blocks(struct kiocb *iocb, struct iov_iter *from)
 			return err;
 	}
 
-	if (direct_io && allow_outplace_dio(inode, iocb, from))
+	if (do_direct_io && allow_outplace_dio(inode, iocb, from))
 		return 0;
 
 	if (is_inode_flag_set(inode, FI_NO_PREALLOC))
-- 
2.23.0