Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Nov 2019 10:45:08 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Changbin Du <changbin.du@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] perf: support multiple debug options separated by
 ','
Message-ID: <20191126094508.GB32367@krava>
References: <20191125151446.10948-1-changbin.du@gmail.com>
 <20191125151446.10948-2-changbin.du@gmail.com>
MIME-Version: 1.0
In-Reply-To: <20191125151446.10948-2-changbin.du@gmail.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 25, 2019 at 11:14:45PM +0800, Changbin Du wrote:
> This patch adds support for multiple debug options separated by ',' and
> non-int values.
> =09--debug verbose=3D2,stderr
>=20
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>  tools/perf/Documentation/perf.txt | 13 +++--
>  tools/perf/util/debug.c           | 89 ++++++++++++++++---------------
>  2 files changed, 53 insertions(+), 49 deletions(-)
>=20
> diff --git a/tools/perf/Documentation/perf.txt b/tools/perf/Documentation=
/perf.txt
> index 3f37ded13f8c..fd8d790f68a7 100644
> --- a/tools/perf/Documentation/perf.txt
> +++ b/tools/perf/Documentation/perf.txt
> @@ -19,13 +19,12 @@ OPTIONS
>  =09  --debug verbose=3D2 # sets verbose =3D 2
> =20
>  =09List of debug variables allowed to set:
> -=09  verbose          - general debug messages
> -=09  ordered-events   - ordered events object debug messages
> -=09  data-convert     - data convert command debug messages
> -=09  stderr           - write debug output (option -v) to stderr
> -=09                     in browser mode
> -=09  perf-event-open  - Print perf_event_open() arguments and
> -=09=09=09     return value
> +=09  verbose=3Dlevel=09=09- general debug messages
> +=09  ordered-events=3Dlevel=09- ordered events object debug messages
> +=09  data-convert=3Dlevel=09- data convert command debug messages
> +=09  stderr=09=09- write debug output (option -v) to stderr
> +=09  perf-event-open=09- Print perf_event_open() arguments and
> +=09                          return value in browser mode

it's just the list and the doc says user can use values
there, so no need for the '=3Dlevel' there

also we allow this:
  perf --debug stderr=3D9 record ls

so I thinks we should keep it general in documentation,
eventhough it will always mean just stderr=3Dtrue for any
value

jirka