Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191125145320.GA21484@haolee.github.io> <bbc278b2-d897-5a43-befd-7be8dacd8495@redhat.com>
In-Reply-To: <bbc278b2-d897-5a43-befd-7be8dacd8495@redhat.com>
From:   Hao Lee <haolee.swjtu@gmail.com>
Date:   Tue, 26 Nov 2019 22:33:10 +0800
Message-ID: <CA+PpKPkW-BAdct2M+HsnM=SR3CNdiFkBP1ROokSJyY6=HvjWuA@mail.gmail.com>
Subject: Re: [PATCH] mm: use the existing variable instead of a duplicate statement
To:     David Hildenbrand <david@redhat.com>
Cc:     akpm@linux-foundation.org, Mel Gorman <mgorman@suse.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 26 Nov 2019 at 20:13, David Hildenbrand <david@redhat.com> wrote:
>
> On 25.11.19 15:53, Hao Lee wrote:
> > The address of zone has been stored in variable 'zone', so there is no need
> > to get it again with a duplicate statement.
> >
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone
> >       for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
> >               struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
> >               unsigned long size;
> >
> >               if (!managed_zone(zone))
> >                       continue;
> >
> >               if (!mem_cgroup_disabled())
> >                       size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
> >               else
> > -                     size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid],
> > -                                    NR_ZONE_LRU_BASE + lru);
> > +                     size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru);
> >               lru_size -= min(size, lru_size);
> >       }
> >
> >       return lru_size;
> >
> >  }
>
> Maybe tweak the subject to something meaningful:
>
> "mm/vmscan: reuse stored zone in lruvec_lru_size()"
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
Thanks. I get it!

Regards,
Hao Lee