Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4398030ybc; Tue, 26 Nov 2019 08:20:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyqAFPW+XRk/8KpfodWjjbVSUp/XfqKbDIOK2T0gACAHnOSZRw2ndKvsv/RPykYsLTWNy00 X-Received: by 2002:a17:906:9248:: with SMTP id c8mr45219659ejx.47.1574785202496; Tue, 26 Nov 2019 08:20:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574785202; cv=none; d=google.com; s=arc-20160816; b=g6FZSAHV2lkgpCHDtZdRlaxPaM8c6Hh3cC88JdyPfoixzicOG2jAIYmdTqRtUbtMNw aSnXIvZ4jLTo408g1130bnZOyl87qwtEZaC/A9qsfi+o+wMEzao3JEU+elabcsL+X42F rRuAly8FPxAgsh3TuV3DuYdjd5XBv7Pq1JlHN5nZteX4j9aS11e+8BNg8AGkX2Z2oWl9 tBFdxt2YbJ4DGSJh9R5ZLpiYLLHA6v/sS5J6pOuEdTVybtErbCf4wJjZrDHpARvW3a37 oDKxd/bcQEpycC4EVRvQuvi5y807UIMlJTErPOJhL4AUacF1zchOiKmF7lcSxQzxm0VV XIVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1B5z3ocoUnAb+PeLyD8I97QacT7fRBDt6WO9TjOiZjQ=; b=WFbf/0jBbH07KhKk+pLiEt+tUf5wHMmY8622Jvkm5s67JWDnM+oTM76f063R88Mz49 ajMoMZsSvn6qU+JpiC0rl00wuWpWN1N2oofqe8wRvRCba2h9JJZCQevS9KKGJa1Nm40b 3K2K3wsfY1GWDDAJj3IoYEAoUs/m6bDP77zzZDkuJN9XRDBlutn19UIv6wMEb5Oxgegk Oj1/gfqdFoQf6uiXXaNscv2hkUp7eu+tjvAr4MFzR6AKM6X+DIMwaU+4pckc7EeIWt6T hgc7/NA6WkZMMtFWDYbv8T9QpTptW3UVj7OBY88OXUjRdyIbaiAFxf0h1rAp5Hlzu4R4 USLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ReBaqs3k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v15si138823eds.318.2019.11.26.08.19.37; Tue, 26 Nov 2019 08:20:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ReBaqs3k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728507AbfKZPcC (ORCPT + 99 others); Tue, 26 Nov 2019 10:32:02 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27814 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728479AbfKZPcB (ORCPT ); Tue, 26 Nov 2019 10:32:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574782320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1B5z3ocoUnAb+PeLyD8I97QacT7fRBDt6WO9TjOiZjQ=; b=ReBaqs3k9hxgc//6t9Rd/+3YOKBpjpONidmvm0F83Hy3yFf/j06gelMtiNRh1r5PP08DvP i04/8JU45SkVISSVnZlcT7N6B5Neq+GjBnGQII516ir7O+3JVRGYUWApCyrs+wWeigfLUm b3gtUfiM8JwYIoC0EeedYBtxlhnq+mA= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-s1CmBi2DP1-3BTLketZoqw-1; Tue, 26 Nov 2019 10:31:59 -0500 Received: by mail-pj1-f70.google.com with SMTP id o34so51848pjb.15 for ; Tue, 26 Nov 2019 07:31:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1B5z3ocoUnAb+PeLyD8I97QacT7fRBDt6WO9TjOiZjQ=; b=Zj+fHAArpsHzUxrG7PY5sgl+qF/Qg4RoBl1gtKH4WXv3h3Lr5FHaUKHkVuoePSdEg7 zmjgFyUvOvBzVwDPvqja2rSrlgTYpmtMCcicj+7YvnyNcW0qP+XdszxeQOXE5neU6795 9TOwsOLhNZ5zSiFKE3/fmXlkWMGM83UM2dWmxbvurNDQJlaQ8O83P67hg7DP/Ct0KwF0 X1vP7jOLE+XuJk1iE+ZiMbfC4RirJj8/9WLBC3Fy6tkZspyz++1JfUJQA8NLrXIixTne BXhNW4oUhhVKgfAz3/wbGJOVz3JiSPqtTzmP54RhnayDZ3QxGw+gsGVl6FQMpeeHaE9e 8irA== X-Gm-Message-State: APjAAAXl3fjjNoVg9XNTKw9c4eLywGsECxgGBJKQIdgAVO2eQZ66gKXD hC0lL8lTYXsgzv8XqkZGu3AVBO2dDyARCHG5FWWmH1fAXgEltLbZ02/6Q/ylEGwVvxUVWVrvcXH eYviWR2w2m2a/x6QFPMJj+982 X-Received: by 2002:a17:90a:3522:: with SMTP id q31mr7781090pjb.18.1574782318075; Tue, 26 Nov 2019 07:31:58 -0800 (PST) X-Received: by 2002:a17:90a:3522:: with SMTP id q31mr7781055pjb.18.1574782317801; Tue, 26 Nov 2019 07:31:57 -0800 (PST) Received: from trix.remote.csb ([75.142.250.213]) by smtp.gmail.com with ESMTPSA id 136sm13292798pfb.49.2019.11.26.07.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Nov 2019 07:31:57 -0800 (PST) Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock To: Joerg Vehlow , linux-kernel@vger.kernel.org, bigeasy@linutronix.de Cc: Joerg Vehlow References: <20191126071335.34661-1-lkml@jv-coder.de> From: Tom Rix Message-ID: <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com> Date: Tue, 26 Nov 2019 07:31:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20191126071335.34661-1-lkml@jv-coder.de> Content-Language: en-US X-MC-Unique: s1CmBi2DP1-3BTLketZoqw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Why remove the #ifdef CONFIG_PREEMPT.. ? > + spin_lock_irqsave(&trans->queue.lock, flags); > skb_queue_splice_init(&trans->queue, &queue); > + spin_unlock_irqrestore(&trans->queue.lock, flags); > Fine otherwise. Tom