Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Nov 2019 18:00:12 +0100
From:   David Sterba <dsterba@suse.cz>
To:     Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc:     linux-kernel@vger.kernel.org, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, anand.jain@oracle.com,
        Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH 0/2] btrfs qgroup cleanup
Message-ID: <20191126170011.GN2734@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz,
        Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
        linux-kernel@vger.kernel.org, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, anand.jain@oracle.com,
        Marcos Paulo de Souza <mpdesouza@suse.com>
References: <20191126005851.11813-1-marcos.souza.org@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191126005851.11813-1-marcos.souza.org@gmail.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 25, 2019 at 09:58:49PM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> While reading the qgroup code and doing some tests, I found some two things
> that I would like to change:
> * Remove some useless code that was being set only to check if
>   fs_info->quota_root was not NULL
> * Check why creating a qgroup was returning EINVAL
> 
> The answer to the second point was: EINVAL is returned when a user tries to
> create/delete/list/assign a qgroup to a subvolume, but this subvolume does
> not have quota enabled. Talking with David, he suggested to change it to
> ENOTCONN, following what is currently being used in balance and scrub.
> 
> So here are the changes. Please take a look!

Added to misc-next with minor subject edits, thanks.