Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4599846ybc; Tue, 26 Nov 2019 11:27:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzu3MgPd4YlsHyXQ5uLIaz7k+iQ2evtqpRGIViwaqCmVRT6LkdXt/B13GvU6VY89KtL4dun X-Received: by 2002:a05:6402:2d8:: with SMTP id b24mr2460439edx.67.1574796460272; Tue, 26 Nov 2019 11:27:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574796460; cv=none; d=google.com; s=arc-20160816; b=wBfBXxkTd7+65TXO/YwDUM0vfJBUxze10PgdhFcCVupplegWVudCns2iiNuaassHTa 6zvDerm2SyYC1RySAtUXo6IHWO2+EnywKFfOwOiOWfiyha/tQrnN6BEyis9qFe8APwhL hvWz/CL46sH9FiiTu8k5KvOXxFr8acv3m0TmAk20U+QhSouDbuuudibsL7/vrlDmOLM9 Pz4UkGe3p/TyQyTaH0wc/Ih9d2/2ivOZja1bfH2Enbex4Ti3YPmitRJoa5Ar7mVv62qg b4hpy2GdeONHqkC2I6JEUCh/jXE48XIkDnVVy9ZdaUim0wtBqjbH7YCWdCPHoPRw5Peo T5sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=SB420jh+8J99NcbUhVfjLnsfSRGlx/ZCsY2FzPg4HR0=; b=JMq28BNaxFIBo+jwi5pdb88XfAm5UKc6HgOmVaJaB+O+dji5NS5uso551qwdYg6b5N vKJVfz6KVSoPb/vjvsQU6fNS4SPKv7KOob0xR8HUBVVkeSIzgw4muA1SnG5rBUaRIgiA oheQwXKajpY7HYQuWnEte08vGgUMfw1w+ax7VvwNGP3nrrmekxjKGrJBruV3HZbA2/93 DJyjA0LGVcouUzmG6ot2XRkr8gZFrTc79cW6y19VstwUPXBe+SFY/eW7zkpF7gjJ8zCw 9BZUXhWpkIXhiJfl4pjkduXnyUTHpXR6DL9C7CIde7JP5D7fzrrHDrYCVAUY2sidNOPN ZNlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u15si8180219ejb.120.2019.11.26.11.27.15; Tue, 26 Nov 2019 11:27:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbfKZTYv (ORCPT + 99 others); Tue, 26 Nov 2019 14:24:51 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:49834 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfKZTYu (ORCPT ); Tue, 26 Nov 2019 14:24:50 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id B03BA20055; Tue, 26 Nov 2019 20:24:46 +0100 (CET) Date: Tue, 26 Nov 2019 20:24:45 +0100 From: Sam Ravnborg To: Mihail Atanassov Cc: Daniel Vetter , "dri-devel@lists.freedesktop.org" , David Airlie , nd , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/30] drm: Introduce drm_bridge_init() Message-ID: <20191126192445.GA2044@ravnborg.org> References: <20191126131541.47393-1-mihail.atanassov@arm.com> <20191126131541.47393-2-mihail.atanassov@arm.com> <20191126142610.GV29965@phenom.ffwll.local> <11447519.fzG14qnjOE@e123338-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11447519.fzG14qnjOE@e123338-lin> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=oJJ1f2mEg_3WOdBYLHIA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mihail. > Ack, but with one caveat: bridge->dev is the struct drm_device that is > the bridge client, we need to add a bridge->device (patch 29 in this > series) which is the struct device that will manage the bridge lifetime. Other places uses the variable name "drm" for a drm_device. This is less confusion than the "dev" name. It seems a recent trend to use the variable name "drm" so you can find a lot of places using "dev". bike-shedding - but also about readability. Sam