Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4637337ybc; Tue, 26 Nov 2019 12:06:16 -0800 (PST) X-Google-Smtp-Source: APXvYqyRZik3HYwUPZqCEB54BGAzDa7YlXchgU9oysnr5/EE22R5HfDp0XwRCR0xy/nqbzmMBKKl X-Received: by 2002:a17:906:b25a:: with SMTP id ce26mr44608310ejb.13.1574798775913; Tue, 26 Nov 2019 12:06:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574798775; cv=none; d=google.com; s=arc-20160816; b=mcQG4bE7elq37w835in+34f35hHH96Dnn3DB56E41xwwmowz3Co6mT1412HB+oHQpG XLAcryPOkk1rgmP2BfiGW1jK+ZMHsAyz+fWW9Aqdo0JxY872bGREJwN6Xtg6q90xKWry IKFF6X+450aB2hr0GkSqjhGOFtKEBOk4elwbJtcrqm1r7z7HR5IIaEU71XLmm1zGwaOo AJc2Lf1upSS+WB5UAUuyRQt46Z2TH8VQxpWmkl9DFY+0a3zsZ+YuqaKRuDtJZsstzAoR Dus6CxqJMFSTNBSWYIps371NlDi3vm/p/0fJuIMzL/J3fWY3UeC+vYLcfG/VMc0Azf0s k2QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=tWV9arggnPlqa0lazxpcwxfW6DO0FvZ1dHAsZFOz/2Q=; b=rtD5KeQS0yGxbHgqhm4idfCmmn5IAozKM2ZWfZLo0R/ISAXBnt7vNhu3r7zisM+XmU XVPfgI62FExcc9w1LwvnnAUYbEW9VuwsBMh0z4u4JPmfjX2K2Z/qIhNANm0Lit1M5sOi hK85aUMN+csFQlWh6HxyUHS/LsWKtNXPWDZ1WHfJDERomEZsq5+we1Y5eyjiTlkDl7cW rUYPEVkpHoNmsusRmKvpqovULQ2z7Rj/jG1x5euFDTxJXHxxpBIKs6ladZG4w5xwwVGa 878h83zBUtt/hEUljx/QwYA83Q+BsYlyyaHDKLJZtvP1BGj9hhoJHoXGuN2oYcHOaATq Z8GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WsPvXjG5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z58si8640596edz.141.2019.11.26.12.05.49; Tue, 26 Nov 2019 12:06:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WsPvXjG5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbfKZUD4 (ORCPT + 99 others); Tue, 26 Nov 2019 15:03:56 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43646 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbfKZUD4 (ORCPT ); Tue, 26 Nov 2019 15:03:56 -0500 Received: by mail-lj1-f193.google.com with SMTP id y23so21679047ljh.10 for ; Tue, 26 Nov 2019 12:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tWV9arggnPlqa0lazxpcwxfW6DO0FvZ1dHAsZFOz/2Q=; b=WsPvXjG5t74MPCFoRSj5L+BalU5zqcKRAVt7HyQM8jo02n6sA2b1cJrmb3EV7BYp3n du2/QOrTOQFvmdBWqbFNwITB5p5iP9gO1lvitMNJM7sKQCZ4Lkhyj0cOkbV15nePagsQ oxnsIpG0jie9HZxKh87rV4lPw8f0at7/W135w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tWV9arggnPlqa0lazxpcwxfW6DO0FvZ1dHAsZFOz/2Q=; b=cZ1r+Vre1mSApw3tNWDW7jmp/GcEWS9apEmbdVuASax9ugrZFOB1oKcJN+J+RR91jy LUs6CDBt63VxWs1mmwKcXxfkHJijJINSi7F0ko/65TgrTzERVo2lY4xK91Ux5PPXEWbs G3zMyqMdg+wv6Gpqs653N5dKjdBtjJh+8Dc+B4nu33jRK0axD8oMceDFmUFg9My0f+wq U/7ph0AocVmkhIXkHF87hobSW30jMfNjNSkZw6acK1dfSRqQVf55dkemcQuDupyWeBZi Ty9O+jUbS4n8/S9pRbcro2o3dsYZRiw+jnzcCRnF/MCNUojQJNmN12HWY+lDezeqM+It XgBA== X-Gm-Message-State: APjAAAWIIYtbB/rg2k1p0HMOfY/mr4Kax0Y73Wqlz5cipTJAAbyYmwfp jhVYU1siVF59LTMkadlTn0N6Ou4tpXE= X-Received: by 2002:a2e:9cc4:: with SMTP id g4mr24809885ljj.99.1574798634109; Tue, 26 Nov 2019 12:03:54 -0800 (PST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id y6sm5918969ljn.40.2019.11.26.12.03.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Nov 2019 12:03:53 -0800 (PST) Received: by mail-lj1-f177.google.com with SMTP id e10so12536434ljj.6 for ; Tue, 26 Nov 2019 12:03:53 -0800 (PST) X-Received: by 2002:a2e:84d0:: with SMTP id q16mr16849464ljh.48.1574798632799; Tue, 26 Nov 2019 12:03:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Tue, 26 Nov 2019 12:03:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Commit 0be0ee71 ("fs: properly and reliably lock f_pos in fdget_pos()") breaking userspace To: "Kenneth R. Crudup" Cc: Linux Kernel Mailing List , Kirill Smelkov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 25, 2019 at 7:39 PM Linus Torvalds wrote: > > I think I'll have to revert that trial commit. I'll give it another > day in case somebody has a better idea, but it looks like it's too > early to do that nice cleanup as things are now. I've reverted it for now, I don't want this problem to cause people to report known bugs during the merge window. The fact that I saw no issues obviously is just a matter of my workloads being too simple. Linus