Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4653851ybc; Tue, 26 Nov 2019 12:22:42 -0800 (PST) X-Google-Smtp-Source: APXvYqyziZWAW2vyejmHlFW1SxEOOrabvePoaZCUYDuUXzMkHpXo428pR1FzSjdlg0sy/lHymRTn X-Received: by 2002:a17:906:12d3:: with SMTP id l19mr43403594ejb.165.1574799762815; Tue, 26 Nov 2019 12:22:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574799762; cv=none; d=google.com; s=arc-20160816; b=hkz1kd7m0TIUBSAdZcfuJMiPBLe6w6IKboQmuvoeGhgDegPLrtT4TKZm9BT6JA8skR o/xDUY17mqA1jnn91bHq5mDDm2UajXXFFzzhDVpK0gzDjYr1Zq2VLUU+t0XzQQ5ArHfi MSjQMqeX/+lDL8rKhoMWq1i69458lc2bfewXf/EIniLrGRnxetjT9FqdEwUjALHbS7hs 3i+xuknuIr0XDydAA1xqHrIbXsgN0f5CtYdu8Asxpz9Fb82gwhH/W3FVxfyUrIb4yT/V 6tgTZQ8/pJpU/I0VKVOV6WcBqX7rYu9SCGg+D7bfiZtuWqvW2DQdkcjVZzlIiiK5ytLb 9AYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=RDc/7UTiWgRNJUQDLRY2cv2eHgMEZbIXNNNWVVW8wC8=; b=UcYIjjouA5aD8zjezeN8QCb6G+vytCD2N5lVxALTnJvD2AWeYBFo0oX+g/xWtIQjx9 S+2VC7heaYnOVgRe4PD9FR1fuh7mHGo5yplJlEdKczjaKLxxiucZo6673Mx3m2BBuur1 l0idXx8biMKT1+67ofJF8fHZPcsFZzvVhmMlBP1QjhKejE8xk7NoFiatkfVvNEiq0WmD 63zSfwdA49gzx7e68ODZdIgC4YGlDNZR+QhH171qWrUbQWepVFytkmkjOn/q0wMNSnxT h8Werq7/a3UkLZma1yIGWBfJze6yuVNXl5o2nU0lFQZenjNNttJPICjx66dT6vXWu3nN iSfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si1613110edv.432.2019.11.26.12.22.18; Tue, 26 Nov 2019 12:22:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbfKZUTM (ORCPT + 99 others); Tue, 26 Nov 2019 15:19:12 -0500 Received: from mga17.intel.com ([192.55.52.151]:27752 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfKZUTM (ORCPT ); Tue, 26 Nov 2019 15:19:12 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 12:19:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,246,1571727600"; d="scan'208";a="359273878" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga004.jf.intel.com with ESMTP; 26 Nov 2019 12:19:11 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 879BC300B64; Tue, 26 Nov 2019 12:19:11 -0800 (PST) From: Andi Kleen To: Changbin Du Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/2] perf: add support for logging debug messages to file References: <20191126143720.10333-1-changbin.du@gmail.com> Date: Tue, 26 Nov 2019 12:19:11 -0800 In-Reply-To: <20191126143720.10333-1-changbin.du@gmail.com> (Changbin Du's message of "Tue, 26 Nov 2019 22:37:18 +0800") Message-ID: <87v9r6e6gw.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changbin Du writes: > When in TUI mode, it is impossible to show all the debug messages to > console. This make it hard to debug perf issues using debug messages. > This patch adds support for logging debug messages to file to resolve > this problem. This was already solved in commit f78eaef0e0493f6068777a246b9c4d9d5cf2b7aa Author: Andi Kleen Date: Fri Nov 21 13:38:00 2014 -0800 perf tools: Allow to force redirect pr_debug to stderr. When debugging the tui browser I find it useful to redirect the debug log into a file. Currently it's always forced to the message line. Add an option to force it to stderr. Then it can be easily redirected. You can do perf report --debug stderr 2> file ... -Andi