Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4668210ybc; Tue, 26 Nov 2019 12:38:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyQXS9jUf5w9SkQy1bCc74GSUyyXsCNErJpDwxxXGJbCpL+l4ns6FzxF82l8P0Ve7z24tJg X-Received: by 2002:a50:b4d6:: with SMTP id x22mr769609edd.181.1574800713980; Tue, 26 Nov 2019 12:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574800713; cv=none; d=google.com; s=arc-20160816; b=s74wySBsFAtPDqp8dmWzryDJp3oaBV6XHorRidzxJK0WPDonGwbgHHQ+yqodF2lgdo Orbx2spel81ZMCrY3z2UvEfzw6UerAtnB3pElKv/YSqh7yoUxx0j3Om8p+1pj5uyHMC9 ZpJNmsg9zMtpTIXvDDGPwo7RB6AH74znxtbBk/lMpm1Vw16ePTg/iXqo/CxrRtxbSXFi fFFxlc5kRgcmMaqQspx0sGx5zSMEMWtHQv2BUnFef1pt3tyoe9F0Hh4/kxUgb7eQ13rS oqsjY38TwodEnXjEbQTE50XCp7QO66wu6QGUlQJ2p+3+GVLaydSCF+A00Hu8E9giDUUc nOgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eCiyINJIqZQ9+c/j9O3wV96E5XzkXxVGgIEzTJ6ccpU=; b=TxDvPxMJMBlogoXsHXp2hmbqN/0270h3mpm0XUW24eUUifoSiaw7dG3N9/JSFfcnvN D7zlRHIagPDYJlL/imdwETb45S7b9CJtDi/g2OfLt/lI1N9ITGG54gj+W8si+OTWX1Rz e9iQgQQiVc0YYXQ7KjvIxHZvz6FU4g3Gclbqv2n20qqGVe3pJxg4ttfpKLyb2e7/CD4f GYlc8ID3P3rbEyjgBhcEyBkL9XtgGNTfLMnfaUUiDpWvsGc1CgQ+AR6yCNLIClGmlWo+ Ndr84wi+SWmIRoK6zaX/ecAoMGUMqA3eOWRtIq5cztFhYtD9FH36vAdItHmEMwK9G8Db DrbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22si8367561edv.175.2019.11.26.12.38.10; Tue, 26 Nov 2019 12:38:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbfKZUep (ORCPT + 99 others); Tue, 26 Nov 2019 15:34:45 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:45661 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfKZUep (ORCPT ); Tue, 26 Nov 2019 15:34:45 -0500 Received: by mail-io1-f66.google.com with SMTP id i11so11263782ioi.12; Tue, 26 Nov 2019 12:34:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eCiyINJIqZQ9+c/j9O3wV96E5XzkXxVGgIEzTJ6ccpU=; b=b9k89bAnLmb1qagKi1LUJu3LiGsnN1FMJYFfbWEm0B1GYoV/i4kYtOy1SjGBVDhJDo BMZyY+htPtUlrDiqHFLpyKPtIXFcQYnSM26NHGpR+/QGmvrdgIN4rUVk1EkzJNCjvMM0 d186H016RdIo217/Bd3hDYz4jNiyPwvtKtwHrP0B2lxJkC8quUwPg7qK71o9MRmaUV7k D0yah3csd0n3emtYCzVopi8Yuj13CNWwBbRmXHB0Me8zR7cYsPNzFtaaUvZJpl2dVVmA f6csBLZzRewE3An2VS/xmWydcu0P6Iden6k6ZZ8pOyrVojbd2cp00SGOWg2Qi7zW3AlV GPNA== X-Gm-Message-State: APjAAAXfT5DKO9PIWLIpDl1FIc2YIKt4DWj09knbdKC8NOVMCrR6ON6r CLVowSLYrDdeI9gIVNhrRw== X-Received: by 2002:a6b:f317:: with SMTP id m23mr17361728ioh.303.1574800484514; Tue, 26 Nov 2019 12:34:44 -0800 (PST) Received: from localhost ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id k22sm2923474iot.34.2019.11.26.12.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 12:34:43 -0800 (PST) Date: Tue, 26 Nov 2019 13:34:42 -0700 From: Rob Herring To: Masahiro Yamada Cc: devicetree@vger.kernel.org, Frank Rowand , Michael Ellerman , Russell King , linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h Message-ID: <20191126203442.GA20537@bogus> References: <20191113071202.11287-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113071202.11287-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 13, 2019 at 04:12:02PM +0900, Masahiro Yamada wrote: > The DTC v1.5.1 added references to (U)INT32_MAX. > > This is no problem for user-space programs since defines > (U)INT32_MAX along with (u)int32_t. > > For the kernel space, libfdt_env.h needs to be adjusted before we > pull in the changes. > > In the kernel, we usually use s/u32 instead of (u)int32_t for the > fixed-width types. > > Accordingly, we already have S/U32_MAX for their max values. > So, we should not add (U)INT32_MAX to any more. > > Instead, add them to the in-kernel libfdt_env.h to compile the > latest libfdt. > > Signed-off-by: Masahiro Yamada > --- > > My initial plan was to change this in a series of 3 patches > since it is clean, and reduces the code. > > [1/3] https://lore.kernel.org/patchwork/patch/1147095/ > [2/3] https://lore.kernel.org/patchwork/patch/1147096/ > [3/3] https://lore.kernel.org/patchwork/patch/1147097/ > > 1/3 is stuck in the license bikeshed. > > For 2/3, I have not been able to get Ack from Russell. > > So, I chose a straight-forward fixup. > > > Changes in v3: > - Resend as a single patch > > arch/arm/boot/compressed/libfdt_env.h | 4 +++- > arch/powerpc/boot/libfdt_env.h | 2 ++ > include/linux/libfdt_env.h | 3 +++ > 3 files changed, 8 insertions(+), 1 deletion(-) Applied. Rob