Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4760040ybc; Tue, 26 Nov 2019 14:17:15 -0800 (PST) X-Google-Smtp-Source: APXvYqzzvgbZe35ONB5qIVvnP9H5JSzBHyoJaRanY3BoqZavBZxCQJaBd7Dd8TAfJPuGo2hN1mpF X-Received: by 2002:a50:9b1a:: with SMTP id o26mr27738704edi.208.1574806635204; Tue, 26 Nov 2019 14:17:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574806635; cv=none; d=google.com; s=arc-20160816; b=ayS0EDiM7wxo2czzDQzeH0Qb0DG4eUFUnHDfdIAaJcR32uT0LKrUihCZR8x/gCPO6C F7NSuiRPBlfvbHhngHuka8wbwTyZTcK0hU/REhZ05u5UHgNiEIi+Wfl5fSxoZVVFRTxF fvTDTd+Lli2oy455QOyxugbesqLjky6+6dAoFYIEDvHRuGJ09VA0KniK3isaAFV7WST9 r8TS+mlqgu3w+8xx/caPgVUY51N/PzB6V2451KwQGA1L9DBnoXFZGvDdYEHwU81eyW6f rtq71Da3b+MuL4dklpOCIfara82OkbkFNpcyToPfqBDmFjiPM5lS58H2cZgGLNPEjAjm jqfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=HVLUK+KoL1ObAkoGXHfpyJ7omwFCsNfysiFyDAdW/Wo=; b=uDAsBVbjqqQPC5ceB/GWixWPOfV2nUUakcsnohtiRjbifYbgzGWJatomtbB6HMuHUK F+8EHOf1yMXgY6Xi51x+B/3YKNA6h9wPBU1zSoMg9pbJQ5NgYY0kEE/kVybOt7QXMG9p zYX926jMoIXy3Q2PrD17g2FBPFbj20V5UCF3N013fHTjstRCEYx/WNtjD1FDh7oA/rkW 9zVq03Ei8U3nSVeVVR/v0CFRejjlVoesMivLTU911CPRlfJ82znwaYCSPduLVkh8pab7 eQncre0pGc9OQhmH4OJ7dqHJyD16kifwo20YB/+Iek0nxFDJF5l4wAyvWEWeRZ0D8vZj WXCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si7665400ejx.115.2019.11.26.14.16.50; Tue, 26 Nov 2019 14:17:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbfKZWOM (ORCPT + 99 others); Tue, 26 Nov 2019 17:14:12 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55561 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfKZWOM (ORCPT ); Tue, 26 Nov 2019 17:14:12 -0500 X-Originating-IP: 90.65.92.102 Received: from localhost (lfbn-1-1723-102.w90-65.abo.wanadoo.fr [90.65.92.102]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4D95CFF809; Tue, 26 Nov 2019 22:14:05 +0000 (UTC) Date: Tue, 26 Nov 2019 23:14:04 +0100 From: Alexandre Belloni To: Colin King Cc: Alessandro Zummo , Kevin Hilman , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: meson: remove redundant assignment to variable retries Message-ID: <20191126221404.GT299836@piout.net> References: <20191122225210.109172-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191122225210.109172-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/11/2019 22:52:10+0000, Colin King wrote: > From: Colin Ian King > > The variable retries is being initialized with a value that is never > read and it is being updated later with a new value in a for-loop. > The initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com