Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp5188270ybc; Tue, 26 Nov 2019 23:29:12 -0800 (PST) X-Google-Smtp-Source: APXvYqwzPtcmHZ01sOJl1Mtd3yqWjnqwqACGIkuieDjQ3IlMKl2e1n22RxbScyBm4VFocWaTnJej X-Received: by 2002:a17:906:3107:: with SMTP id 7mr28491495ejx.125.1574839752206; Tue, 26 Nov 2019 23:29:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574839752; cv=none; d=google.com; s=arc-20160816; b=DLp7I1vIEcpLA7ezoimlw3RafyZVCfTBp/DIXTmFTRmzztyGdEXwbEWZ0SO5pjL4fG fUTnecvPGB0kfqeX0O2C+hLhBr6eiuzdlWQz/yZoFWlb2c/MyEw1nZDPfnG97ZKg+JcS AMURAKzpS3aAojGENXRDiYkFvU2cf3PQRtGwYNWzqVGPt0Ib0JJzNK7SLAX/ZAEKF4fr KHE5PoNzxkZZJX/B1yEt7jJtOVtxeSpSfvTI1L8Tm/bqJFPihtdhFOd48bZYr05BBuTq gH8cEFtGLLEBSjAXvi48Q6SYysPWbp34o9RQpHvxUa+1kY/VjOziUGa1m0qt6HFufwqY ck6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=bRC+bfkUHFaUgEKqNmmTljz8O5/LBdVatCPy2tLermg=; b=0+wLfSdXfVO2uCJi29zkciYxarNKRs2phTpNasymWJreDyAJjSSub03bd0OHawmol+ 6qA2mDXIYZ4x1juqv4hzcCqpMtThdwpiLHBRTRPtSbvyCkNbIoW3RUAwgipDq5Dl1t1Y AiMsD3Y5/f7Z85CunCc20mEhRw5QvPXbN/6dOYxCtiGeteq8oSS0xqXDSEUMDlLJ3p26 qeLBNOaP3n1xjCdYP/dl90JqXMeFS607P076VPIVhM9vBVMJZCRuSmbPHHgtS/ineb7q cYtf3yZMqDxCgtucqyizuffhyA54sA+RZM3yFeeKdcLyk/p9xgnQ1v1pZs4eT15cNVeY dzhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb5si2570959edb.252.2019.11.26.23.28.48; Tue, 26 Nov 2019 23:29:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbfK0H13 (ORCPT + 99 others); Wed, 27 Nov 2019 02:27:29 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:35699 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726078AbfK0H13 (ORCPT ); Wed, 27 Nov 2019 02:27:29 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZrjQ-00036Y-IU; Wed, 27 Nov 2019 08:27:24 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iZrjP-00021s-Me; Wed, 27 Nov 2019 08:27:23 +0100 Date: Wed, 27 Nov 2019 08:27:23 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Peng Ma Cc: "linux@rempel-privat.de" , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH] i2c: imx: Defer probing if EDMA not available Message-ID: <20191127072723.7twwbjafqdd22v6m@pengutronix.de> References: <20191127071136.5240-1-peng.ma@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191127071136.5240-1-peng.ma@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Nov 27, 2019 at 07:12:09AM +0000, Peng Ma wrote: > EDMA may be not available or defered due to dependencies on > other modules, If these scenarios is encountered, we should > defer probing. I'd write: i2c: imx: Defer probing if requesting DMA yields EPROBE_DEFER DMA might not be available yet when the i2c device probes. Properly handle EPROBE_DEFER on dma channel allocation by passing on this error. It would be nice to point out where/how this failed for you. Other than that this looks reasonable. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |