Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RT v3] net/xfrm/input: Protect queue with lock
To:     Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        bigeasy@linutronix.de
Cc:     Joerg Vehlow <joerg.vehlow@aox-tech.de>
References: <20191126071335.34661-1-lkml@jv-coder.de>
 <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com>
From:   Joerg Vehlow <lkml@jv-coder.de>
Message-ID: <30b9da41-437a-3b00-8306-82c7c44d1a91@jv-coder.de>
Date:   Wed, 27 Nov 2019 08:35:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <46d5e7ea-011b-a384-ac7a-9ba63bbe9ea5@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tom,

I didn't remove it, I just posted my patch again.
I think it is up to the maintainers to decide if
it is required or not. Most people using the rt
patches will probably have PREEMPT_RT_FULL enabled anyway.
It will never be integrated into mainline kernel, because
the bug is already fixed in 5.0.19.

Jörg


Am 26.11.2019 um 16:31 schrieb Tom Rix:
> Why remove the #ifdef CONFIG_PREEMPT.. ?
>
>
>> +	spin_lock_irqsave(&trans->queue.lock, flags);
>>   	skb_queue_splice_init(&trans->queue, &queue);
>> +	spin_unlock_irqrestore(&trans->queue.lock, flags);
>>   
> Fine otherwise.
>
> Tom
>
>